nacl_io: Add inet_pton() and ip6addr_* consts.

nacl_io: Add inet_pton() and ip6addr_* consts.

BUG=276739
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=239309

[Sam Clegg, 2013-12-06 02:31:36]

Thanks for contributing this!

It will be useful to me in a parallel CL i'm working
on to add getaddrinfo(): https://codereview.chromium.org/99933002/

lgtm, with comments, assuming test pass on trybots.

https://codereview.chromium.org/105943006/diff/60001/native_client_sdk/src/li...
File native_client_sdk/src/libraries/nacl_io/library.dsc (right):

https://codereview.chromium.org/105943006/diff/60001/native_client_sdk/src/li...
native_client_sdk/src/libraries/nacl_io/library.dsc:26: "in6_addr.cc",
Did you forget to upload this file?

https://codereview.chromium.org/105943006/diff/60001/native_client_sdk/src/li...
File native_client_sdk/src/libraries/nacl_io/syscalls/inet_pton.cc (right):

https://codereview.chromium.org/105943006/diff/60001/native_client_sdk/src/li...
native_client_sdk/src/libraries/nacl_io/syscalls/inet_pton.cc:14: #include
<string>
Are you using any of these C++ headers?

If not can we just make this file a .c file like the others in this
folder?

Could probably also revert the header change if you did this.

https://codereview.chromium.org/105943006/diff/60001/native_client_sdk/src/li...
File native_client_sdk/src/libraries/third_party/newlib-extras/netinet6/in6.h
(right):

https://codereview.chromium.org/105943006/diff/60001/native_client_sdk/src/li...
native_client_sdk/src/libraries/third_party/newlib-extras/netinet6/in6.h:221:
#endif
Looks like the convention in these headers is to use __BEGIN_DECLS +
__END_DECLS.

..I didn't realize name mangling also applied to global variables.

[Sergey Ulanov, 2013-12-06 20:20:21]

Are the any special NaCl trybots I need to run this change through?
I tried running test_sdk.py locally - it passed.

https://codereview.chromium.org/105943006/diff/60001/native_client_sdk/src/li...
File native_client_sdk/src/libraries/nacl_io/library.dsc (right):

https://codereview.chromium.org/105943006/diff/60001/native_client_sdk/src/li...
native_client_sdk/src/libraries/nacl_io/library.dsc:26: "in6_addr.cc",
On 2013/12/06 02:31:36, Sam Clegg wrote:
> Did you forget to upload this file?

Added in patch set 3

https://codereview.chromium.org/105943006/diff/60001/native_client_sdk/src/li...
File native_client_sdk/src/libraries/nacl_io/syscalls/inet_pton.cc (right):

https://codereview.chromium.org/105943006/diff/60001/native_client_sdk/src/li...
native_client_sdk/src/libraries/nacl_io/syscalls/inet_pton.cc:14: #include
<string>
On 2013/12/06 02:31:36, Sam Clegg wrote:
> Are you using any of these C++ headers?
No, removed.

> If not can we just make this file a .c file like the others in this
> folder?

Done.

> 
> Could probably also revert the header change if you did this.

It's still needed for C++ code that includes that header.

https://codereview.chromium.org/105943006/diff/60001/native_client_sdk/src/li...
File native_client_sdk/src/libraries/third_party/newlib-extras/netinet6/in6.h
(right):

https://codereview.chromium.org/105943006/diff/60001/native_client_sdk/src/li...
native_client_sdk/src/libraries/third_party/newlib-extras/netinet6/in6.h:221:
#endif
On 2013/12/06 02:31:36, Sam Clegg wrote:
> Looks like the convention in these headers is to use __BEGIN_DECLS +
> __END_DECLS.
> 
> ..I didn't realize name mangling also applied to global variables.

Done.

[Sam Clegg, 2013-12-06 20:57:03]

lgtm, with comments.

"git cl try" should select the correct trybots for this change.  From the looks
of it you found that.

https://codereview.chromium.org/105943006/diff/110001/native_client_sdk/src/l...
File native_client_sdk/src/libraries/nacl_io/in6_addr.c (right):

https://codereview.chromium.org/105943006/diff/110001/native_client_sdk/src/l...
native_client_sdk/src/libraries/nacl_io/in6_addr.c:3: // found in the LICENSE
file.
Use C style commented in C file.

https://codereview.chromium.org/105943006/diff/110001/native_client_sdk/src/l...
native_client_sdk/src/libraries/nacl_io/in6_addr.c:21: #endif  //
defined(PROVIDES_SOCKET_API) && !defined(__GLIBC__)
C style comments.

https://codereview.chromium.org/105943006/diff/110001/native_client_sdk/src/l...
File native_client_sdk/src/libraries/nacl_io/syscalls/inet_pton.c (right):

https://codereview.chromium.org/105943006/diff/110001/native_client_sdk/src/l...
native_client_sdk/src/libraries/nacl_io/syscalls/inet_pton.c:3: // found in the
LICENSE file.
C style comments here and below.

https://codereview.chromium.org/105943006/diff/110001/native_client_sdk/src/l...
native_client_sdk/src/libraries/nacl_io/syscalls/inet_pton.c:145: 
Remove trailing line

[Sergey Ulanov, 2013-12-06 21:15:43]

https://codereview.chromium.org/105943006/diff/110001/native_client_sdk/src/l...
File native_client_sdk/src/libraries/nacl_io/in6_addr.c (right):

https://codereview.chromium.org/105943006/diff/110001/native_client_sdk/src/l...
native_client_sdk/src/libraries/nacl_io/in6_addr.c:3: // found in the LICENSE
file.
On 2013/12/06 20:57:03, Sam Clegg wrote:
> Use C style commented in C file.

Done.

https://codereview.chromium.org/105943006/diff/110001/native_client_sdk/src/l...
native_client_sdk/src/libraries/nacl_io/in6_addr.c:21: #endif  //
defined(PROVIDES_SOCKET_API) && !defined(__GLIBC__)
On 2013/12/06 20:57:03, Sam Clegg wrote:
> C style comments.

Done.

https://codereview.chromium.org/105943006/diff/110001/native_client_sdk/src/l...
File native_client_sdk/src/libraries/nacl_io/syscalls/inet_pton.c (right):

https://codereview.chromium.org/105943006/diff/110001/native_client_sdk/src/l...
native_client_sdk/src/libraries/nacl_io/syscalls/inet_pton.c:3: // found in the
LICENSE file.
On 2013/12/06 20:57:03, Sam Clegg wrote:
> C style comments here and below.

Done.

https://codereview.chromium.org/105943006/diff/110001/native_client_sdk/src/l...
native_client_sdk/src/libraries/nacl_io/syscalls/inet_pton.c:145: 
On 2013/12/06 20:57:03, Sam Clegg wrote:
> Remove trailing line

Done.

[commit-bot: I haz the power, 2013-12-06 21:35:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sergeyu@chromium.org/105943006/130001

[commit-bot: I haz the power, 2013-12-07 02:17:18]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sergeyu@chromium.org/105943006/130001

[commit-bot: I haz the power, 2013-12-07 03:44:46]

Change committed as 239309

[Sam Clegg, 2014-01-25 00:30:07]

https://codereview.chromium.org/105943006/diff/130001/native_client_sdk/src/t...
File native_client_sdk/src/tests/nacl_io_test/socket_test.cc (right):

https://codereview.chromium.org/105943006/diff/130001/native_client_sdk/src/t...
native_client_sdk/src/tests/nacl_io_test/socket_test.cc:398:
TEST(SocketUtilityFunctions, Inet_ptoa) {
Should this test have been called Inet_pton?

https://codereview.chromium.org/105943006/diff/130001/native_client_sdk/src/t...
native_client_sdk/src/tests/nacl_io_test/socket_test.cc:436:
TEST(SocketUtilityFunctions, Inet_ptoa_failure) {
Should this be "pton"?

[Sergey Ulanov, 2014-01-25 02:22:02]

https://codereview.chromium.org/105943006/diff/130001/native_client_sdk/src/t...
File native_client_sdk/src/tests/nacl_io_test/socket_test.cc (right):

https://codereview.chromium.org/105943006/diff/130001/native_client_sdk/src/t...
native_client_sdk/src/tests/nacl_io_test/socket_test.cc:398:
TEST(SocketUtilityFunctions, Inet_ptoa) {
On 2014/01/25 00:30:07, Sam Clegg wrote:
> Should this test have been called Inet_pton?

yes, I'll rename it in a separate CL.

https://codereview.chromium.org/105943006/diff/130001/native_client_sdk/src/t...
native_client_sdk/src/tests/nacl_io_test/socket_test.cc:436:
TEST(SocketUtilityFunctions, Inet_ptoa_failure) {
On 2014/01/25 00:30:07, Sam Clegg wrote:
> Should this be "pton"?

yes