Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issue 1059423002: Add PNaCl release note about how to try out Subzero / which flag to set. (Closed)

Created:
5 years, 8 months ago by jvoung (off chromium)
Modified:
5 years, 8 months ago
CC:
chromium-reviews, binji+watch_chromium.org, native-client-reviews_googlegroups.com, Sam Clegg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add PNaCl release note about how to try out Subzero / which flag to set. BUG= https://code.google.com/p/nativeclient/issues/detail?id=4091 Committed: https://crrev.com/6726704e7ba5b1309ff896be3ad45b8bec092588 Cr-Commit-Position: refs/heads/master@{#324321}

Patch Set 1 #

Total comments: 5

Patch Set 2 : jf review #

Patch Set 3 : ok discuss instead of dev #

Patch Set 4 : flip #

Patch Set 5 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -1 line) Patch
M native_client_sdk/doc_generated/reference/nacl-manifest-format.html View 1 chunk +1 line, -1 line 0 comments Download
M native_client_sdk/doc_generated/sdk/release-notes.html View 1 2 3 4 1 chunk +10 lines, -0 lines 0 comments Download
M native_client_sdk/src/doc/reference/nacl-manifest-format.rst View 1 chunk +2 lines, -0 lines 0 comments Download
M native_client_sdk/src/doc/sdk/release-notes.rst View 1 2 3 4 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (8 generated)
jvoung (off chromium)
5 years, 8 months ago (2015-04-03 21:54:31 UTC) #2
JF
https://codereview.chromium.org/1059423002/diff/1/native_client_sdk/src/doc/sdk/release-notes.rst File native_client_sdk/src/doc/sdk/release-notes.rst (right): https://codereview.chromium.org/1059423002/diff/1/native_client_sdk/src/doc/sdk/release-notes.rst#newcode45 native_client_sdk/src/doc/sdk/release-notes.rst:45: We are working on improvements and adding new targets. ...
5 years, 8 months ago (2015-04-03 22:02:10 UTC) #3
jvoung (off chromium)
https://codereview.chromium.org/1059423002/diff/1/native_client_sdk/src/doc/sdk/release-notes.rst File native_client_sdk/src/doc/sdk/release-notes.rst (right): https://codereview.chromium.org/1059423002/diff/1/native_client_sdk/src/doc/sdk/release-notes.rst#newcode41 native_client_sdk/src/doc/sdk/release-notes.rst:41: mode, with similar code quality. Note that x86-32 NaCl ...
5 years, 8 months ago (2015-04-03 22:18:11 UTC) #4
JF
lgtm
5 years, 8 months ago (2015-04-03 22:24:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1059423002/60001
5 years, 8 months ago (2015-04-03 23:22:57 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/11941) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 8 months ago (2015-04-03 23:28:57 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1059423002/80001
5 years, 8 months ago (2015-04-03 23:40:16 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/54196)
5 years, 8 months ago (2015-04-03 23:50:53 UTC) #14
jvoung (off chromium)
+binji -- JF is in doc OWNERS, but looks like doc_generated doesn't understand that or ...
5 years, 8 months ago (2015-04-08 21:28:18 UTC) #16
binji
lgtm
5 years, 8 months ago (2015-04-08 21:37:39 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1059423002/80001
5 years, 8 months ago (2015-04-08 22:15:20 UTC) #19
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 8 months ago (2015-04-09 00:53:40 UTC) #20
commit-bot: I haz the power
5 years, 8 months ago (2015-04-09 00:54:34 UTC) #21
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/6726704e7ba5b1309ff896be3ad45b8bec092588
Cr-Commit-Position: refs/heads/master@{#324321}

Powered by Google App Engine
This is Rietveld 408576698