Add a validator for intent:// URLs.

chrome/android/javatests/src/org/chromium/chrome/browser/UrlUtilitiesTest.java

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser;
 
 import android.test.InstrumentationTestCase;
 import android.test.suitebuilder.annotation.SmallTest;
 
 import org.chromium.base.test.util.Feature;
@@ skipping 86 matching lines @@
 
         uri = URI.create("chrome://settings:443");
         assertEquals("chrome://settings:443", UrlUtilities.getOriginForDisplay(uri, true));
         assertEquals("settings:443", UrlUtilities.getOriginForDisplay(uri, false));
 
         uri = URI.create("about:blank");
         assertEquals("about:blank", UrlUtilities.getOriginForDisplay(uri, true));
         assertEquals("about:blank", UrlUtilities.getOriginForDisplay(uri, false));
     }
 
+    @SmallTest
+    public void testValidateIntentUrl() {
+        String[] expectedTrue = {
+            "intent://10010#Intent;scheme=tel;action=com.google.android.apps."
+                + "authenticator.AUTHENTICATE;end",
+            "intent://scan/#Intent;package=com.google.zxing.client.android;"
+                + "scheme=zxing;end;"
+        };
+
+        for (int i = 0; i < expectedTrue.length; ++i) {
+            assertTrue(UrlUtilities.validateIntentUrl(expectedTrue[i]));
+        }
+
+        String[] expectedFalse = {
+            "intent://10010#Intent;scheme=tel;action=com.google.android.apps."
+                + "authenticator.AUTHENTICATE;end','*');"

[Yaron, 2015/04/24 16:04:18]

There's a lot of other validation that is currently untested.

Are there plausible exploits for fields other than "action" that we can add
tests for?

[palmer, 2015/04/24 18:05:22]

Definitely. Adding more tests now. The above was written quickly before heading
home last night, just to get something for you all to look at. :)

+                + "alert(document.cookie);//"
+        };
+
+        for (int i = 0; i < expectedFalse.length; ++i) {
+            assertFalse(UrlUtilities.validateIntentUrl(expectedFalse[i]));
+        }
+    }
+
 }