Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1059413002: Use SyncCustomizationFragment directly now that it is upstream. (Closed)

Created:
5 years, 8 months ago by aurimas (slooooooooow)
Modified:
5 years, 8 months ago
Reviewers:
newt (away)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use SyncCustomizationFragment directly now that it is upstream. - Stops using ChromiumApplication to launch into Sync settings. - Adds OWNERS file for firstrun package. BUG=None Committed: https://crrev.com/775fd4353888a7d069b16dedc7ee8fdf9f0f408d Cr-Commit-Position: refs/heads/master@{#323842}

Patch Set 1 #

Patch Set 2 : Add owners #

Patch Set 3 : Actually add owners #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunSignInProcessor.java View 3 chunks +11 lines, -2 lines 1 comment Download
A + chrome/android/java/src/org/chromium/chrome/browser/firstrun/OWNERS View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
aurimas (slooooooooow)
newt: PTAL
5 years, 8 months ago (2015-04-03 21:37:02 UTC) #2
newt (away)
lgtm https://chromiumcodereview.appspot.com/1059413002/diff/40001/chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunSignInProcessor.java File chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunSignInProcessor.java (left): https://chromiumcodereview.appspot.com/1059413002/diff/40001/chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunSignInProcessor.java#oldcode198 chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunSignInProcessor.java:198: ((ChromiumApplication) mActivity.getApplication()).openSyncSettings(accountName); be sure to delete ChromiumApplication.openSyncSettings() once ...
5 years, 8 months ago (2015-04-03 21:45:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1059413002/40001
5 years, 8 months ago (2015-04-03 21:53:26 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 8 months ago (2015-04-03 22:52:14 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-03 22:54:02 UTC) #7
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/775fd4353888a7d069b16dedc7ee8fdf9f0f408d
Cr-Commit-Position: refs/heads/master@{#323842}

Powered by Google App Engine
This is Rietveld 408576698