Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(513)

Issue 1059403002: cc: Make the invalidation frequency buffer bigger. (Closed)

Created:
5 years, 8 months ago by vmpstr
Modified:
5 years, 8 months ago
Reviewers:
danakj, enne (OOO)
CC:
cc-bugs_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Make the invalidation frequency buffer bigger. With large enough tiles we can get visible checkerboards if the buffer we use for invalidation frequency is too small. Note that this fix is a work around to make this case less likely to hit. The proper fix is to stop repainting off screen frequently invalidating content at a higher level. R=enne, danakj BUG=467197 Committed: https://crrev.com/ba84d9f7d200b847d5d6cefefa324f972f9541aa Cr-Commit-Position: refs/heads/master@{#323838}

Patch Set 1 #

Patch Set 2 : todo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -15 lines) Patch
M cc/resources/picture_pile.cc View 1 1 chunk +3 lines, -1 line 0 comments Download
M cc/resources/picture_pile_unittest.cc View 4 chunks +19 lines, -14 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
vmpstr
Please take a look.
5 years, 8 months ago (2015-04-03 21:10:57 UTC) #1
enne (OOO)
lgtm
5 years, 8 months ago (2015-04-03 21:13:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1059403002/20001
5 years, 8 months ago (2015-04-03 21:13:40 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-03 22:35:20 UTC) #5
commit-bot: I haz the power
5 years, 8 months ago (2015-04-03 22:36:43 UTC) #6
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ba84d9f7d200b847d5d6cefefa324f972f9541aa
Cr-Commit-Position: refs/heads/master@{#323838}

Powered by Google App Engine
This is Rietveld 408576698