Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 1059383002: Disable dev channel crashes for Extension JS exceptions. (Closed)

Created:
5 years, 8 months ago by not at google - send to devlin
Modified:
5 years, 8 months ago
Reviewers:
Yoyo Zhou
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable dev channel crashes for Extension JS exceptions. This is a temporary patch so that the next dev release branch won't have high crash rates due to this bug. The crash is explicitly disabled on stable and beta branches anyway. Once dev next branches, this will be reverted as we return to trying to fix it. BUG=471599 R=yoz@chromium.org Committed: https://crrev.com/d774155ed89969a8181932f9f2db8ebc179f5b5e Cr-Commit-Position: refs/heads/master@{#323841}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/common/extensions/chrome_extensions_client.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
not at google - send to devlin
5 years, 8 months ago (2015-04-03 20:08:57 UTC) #1
Yoyo Zhou
LGTM, seems legit.
5 years, 8 months ago (2015-04-03 20:18:56 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1059383002/1
5 years, 8 months ago (2015-04-03 21:34:22 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-03 22:50:52 UTC) #5
commit-bot: I haz the power
5 years, 8 months ago (2015-04-03 22:54:00 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d774155ed89969a8181932f9f2db8ebc179f5b5e
Cr-Commit-Position: refs/heads/master@{#323841}

Powered by Google App Engine
This is Rietveld 408576698