Add --uninterestingHashesFile to DM

Add --uninterestingHashesFile to DM

The file is expected to contain a list of strings. If the hash for
any result is in this file, don't write an image for it.

BUG=skia:3521
Committed: https://skia.googlesource.com/skia/+/09ed480906881b6f84bb28c772786928ba3a59d6

[borenet, 2015-04-03 19:36:44]

borenet@google.com changed reviewers:
+ mtklein@google.com

[mtklein, 2015-04-03 19:58:04]

https://codereview.chromium.org/1059363002/diff/1/dm/DM.cpp
File dm/DM.cpp (right):

https://codereview.chromium.org/1059363002/diff/1/dm/DM.cpp#newcode146
dm/DM.cpp:146: static SkTDict<bool> gUninterestingHashes(0);
Let's try:
  static SkTHashSet<SkString> gUninterestingHashes;

The loop would be

  for (const SkString& hash : lines) {
     gUninterestingHashes.add(hash);
  }

and the check:
  && !gUninterestingHashes.contains(md5) {

[borenet, 2015-04-03 20:26:51]

https://codereview.chromium.org/1059363002/diff/1/dm/DM.cpp
File dm/DM.cpp (right):

https://codereview.chromium.org/1059363002/diff/1/dm/DM.cpp#newcode146
dm/DM.cpp:146: static SkTDict<bool> gUninterestingHashes(0);
On 2015/04/03 19:58:04, mtklein wrote:
> Let's try:
>   static SkTHashSet<SkString> gUninterestingHashes;
> 
> The loop would be
> 
>   for (const SkString& hash : lines) {
>      gUninterestingHashes.add(hash);
>   }
> 
> and the check:
>   && !gUninterestingHashes.contains(md5) { 

Done.

https://codereview.chromium.org/1059363002/diff/40001/dm/DM.cpp
File dm/DM.cpp (right):

https://codereview.chromium.org/1059363002/diff/40001/dm/DM.cpp#newcode151
dm/DM.cpp:151: SkData* data = SkData::NewFromFileName(path.c_str());
Am I leaking this?

[mtklein, 2015-04-03 20:35:48]

lgtm after the nits below

https://codereview.chromium.org/1059363002/diff/40001/dm/DM.cpp
File dm/DM.cpp (right):

https://codereview.chromium.org/1059363002/diff/40001/dm/DM.cpp#newcode20
dm/DM.cpp:20: #include "SkJSONCPP.h"
Die?

https://codereview.chromium.org/1059363002/diff/40001/dm/DM.cpp#newcode23
dm/DM.cpp:23: #include "SkTDict.h"
Die?

https://codereview.chromium.org/1059363002/diff/40001/dm/DM.cpp#newcode48
dm/DM.cpp:48: "JSON file containing a list of uninteresting hashes. If a result
hashes to something in "
Update?

https://codereview.chromium.org/1059363002/diff/40001/dm/DM.cpp#newcode151
dm/DM.cpp:151: SkData* data = SkData::NewFromFileName(path.c_str());
On 2015/04/03 20:26:50, borenet wrote:
> Am I leaking this?

Yep.

SkAutoTUnref<SkData> data(SkData::NewFromFileName(path.c_str()));

Actually, I'd write this:

SkAutoTUnref<SkData>
data(SkData::NewFromFileName(FLAGS_uninterestingHashesFile[0]));

[borenet, 2015-04-03 20:40:15]

https://codereview.chromium.org/1059363002/diff/40001/dm/DM.cpp
File dm/DM.cpp (right):

https://codereview.chromium.org/1059363002/diff/40001/dm/DM.cpp#newcode20
dm/DM.cpp:20: #include "SkJSONCPP.h"
On 2015/04/03 20:35:47, mtklein wrote:
> Die?

Done.

https://codereview.chromium.org/1059363002/diff/40001/dm/DM.cpp#newcode23
dm/DM.cpp:23: #include "SkTDict.h"
On 2015/04/03 20:35:47, mtklein wrote:
> Die?

Done.

https://codereview.chromium.org/1059363002/diff/40001/dm/DM.cpp#newcode48
dm/DM.cpp:48: "JSON file containing a list of uninteresting hashes. If a result
hashes to something in "
On 2015/04/03 20:35:47, mtklein wrote:
> Update?

Done.

https://codereview.chromium.org/1059363002/diff/40001/dm/DM.cpp#newcode151
dm/DM.cpp:151: SkData* data = SkData::NewFromFileName(path.c_str());
On 2015/04/03 20:35:47, mtklein wrote:
> On 2015/04/03 20:26:50, borenet wrote:
> > Am I leaking this?
> 
> Yep.
> 
> SkAutoTUnref<SkData> data(SkData::NewFromFileName(path.c_str()));
> 
> Actually, I'd write this:
> 
> SkAutoTUnref<SkData>
> data(SkData::NewFromFileName(FLAGS_uninterestingHashesFile[0]));

Done.

[borenet, 2015-04-03 20:40:19]

The CQ bit was checked by borenet@google.com

[borenet, 2015-04-03 20:40:19]

The patchset sent to the CQ was uploaded after l-g-t-m from mtklein@google.com
Link to the patchset: https://codereview.chromium.org/1059363002/#ps60001
(title: "Address comments")

[commit-bot: I haz the power, 2015-04-03 20:40:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1059363002/60001

[commit-bot: I haz the power, 2015-04-03 20:42:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-03 20:42:01]

Try jobs failed on following builders:
  Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)
  Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on client.skia
(JOB_FAILED,
http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2...)

[mtklein, 2015-04-03 21:01:07]

https://codereview.chromium.org/1059363002/diff/60001/dm/DM.cpp
File dm/DM.cpp (right):

https://codereview.chromium.org/1059363002/diff/60001/dm/DM.cpp#newcode148
dm/DM.cpp:148: SkAutoTUnref<SkData>
data(SkData::NewFromFileName(FLAGS_FLAGS_uninterestingHashesFile[0]));
I think you may have meant
FLAGS_FLAGS_FLAGS_FLAGS_FLAGS_uninterestingHashesFile[0]

[borenet, 2015-04-03 21:09:09]

https://codereview.chromium.org/1059363002/diff/60001/dm/DM.cpp
File dm/DM.cpp (right):

https://codereview.chromium.org/1059363002/diff/60001/dm/DM.cpp#newcode148
dm/DM.cpp:148: SkAutoTUnref<SkData>
data(SkData::NewFromFileName(FLAGS_FLAGS_uninterestingHashesFile[0]));
On 2015/04/03 21:01:07, mtklein wrote:
> I think you may have meant
> FLAGS_FLAGS_FLAGS_FLAGS_FLAGS_uninterestingHashesFile[0]

MOAR_MOAR_MOAR

[borenet, 2015-04-03 21:09:12]

The CQ bit was checked by borenet@google.com

[borenet, 2015-04-03 21:09:13]

The patchset sent to the CQ was uploaded after l-g-t-m from mtklein@google.com
Link to the patchset: https://codereview.chromium.org/1059363002/#ps80001
(title: "Fix TYPO_TYPO")

[commit-bot: I haz the power, 2015-04-03 21:09:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1059363002/80001

[commit-bot: I haz the power, 2015-04-03 21:15:39]

Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/09ed480906881b6f84bb28c772786928ba3a59d6