Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 1059353003: Add missing check for quitting from MessagePumpLibevent (Closed)

Created:
5 years, 8 months ago by Chirantan Ekbote
Modified:
5 years, 8 months ago
Reviewers:
Lei Zhang, sadrul
CC:
chromium-reviews, erikwright+watch_chromium.org, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-land: Add missing check for quitting from MessagePumpLibevent If a MessagePumpLibevent has no tasks to run, it will call libevent's event_base_loop with EVLOOP_ONCE. However, it may turn out that the event that finally runs actually quits the MessageLoop. In this case, there is an off-by-one error where MessagePumpLibevent will call the MessageLoop's DoWork function once before realizing that it was actually asked to quit. Add a check to prevent this from happening. BUG=473693 Committed: https://crrev.com/ee9b754ba442a4c77c67f56caf465b3d9d13d97f Cr-Commit-Position: refs/heads/master@{#323834}

Patch Set 1 : Original CL #

Patch Set 2 : Use WaitableEventWatcher #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -3 lines) Patch
M base/message_loop/message_pump_libevent.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M base/message_loop/message_pump_libevent_unittest.cc View 1 5 chunks +70 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Chirantan Ekbote
ptal
5 years, 8 months ago (2015-04-03 20:26:17 UTC) #2
Lei Zhang
lgtm
5 years, 8 months ago (2015-04-03 21:45:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1059353003/20001
5 years, 8 months ago (2015-04-03 21:53:25 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-03 22:28:26 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-03 22:29:50 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ee9b754ba442a4c77c67f56caf465b3d9d13d97f
Cr-Commit-Position: refs/heads/master@{#323834}

Powered by Google App Engine
This is Rietveld 408576698