Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 1059343002: Add experiment to disable loading of background tabs during session restore. (Closed)

Created:
5 years, 8 months ago by Georges Khalil
Modified:
5 years, 8 months ago
Reviewers:
gab, sky
CC:
chromium-reviews, gab, chrisha
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add experiment to disable loading of background tabs during session restore. BUG=465815 Committed: https://crrev.com/fbcd45d1f21b87e0b70111fded7c805db06a43ea Cr-Commit-Position: refs/heads/master@{#324041}

Patch Set 1 : #

Total comments: 4

Patch Set 2 : Fix metrics by keeping right number of tabs restored. #

Total comments: 1

Patch Set 3 : Remove active_only_ and propagate active_only instead. #

Patch Set 4 : Change default behavior when experiment is missing. #

Total comments: 1

Patch Set 5 : Add comment about |active_tabs|. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -10 lines) Patch
M chrome/browser/sessions/session_restore_delegate.cc View 1 2 3 2 chunks +11 lines, -2 lines 0 comments Download
M chrome/browser/sessions/session_restore_stats_collector.h View 1 2 3 4 2 chunks +10 lines, -4 lines 0 comments Download
M chrome/browser/sessions/session_restore_stats_collector.cc View 1 2 3 chunks +10 lines, -4 lines 0 comments Download

Messages

Total messages: 27 (15 generated)
Georges Khalil
PTAL.
5 years, 8 months ago (2015-04-03 19:14:28 UTC) #5
sky
https://codereview.chromium.org/1059343002/diff/60001/chrome/browser/sessions/session_restore_delegate.cc File chrome/browser/sessions/session_restore_delegate.cc (right): https://codereview.chromium.org/1059343002/diff/60001/chrome/browser/sessions/session_restore_delegate.cc#newcode16 chrome/browser/sessions/session_restore_delegate.cc:16: base::FieldTrialList::Find("SessionRestoreBackgroundLoading"); Can you elaborate on the value of running ...
5 years, 8 months ago (2015-04-03 20:59:10 UTC) #6
Georges Khalil
PTAnL. - Simplified tab_count_ usage - Collector is now aware of the mode (active tabs ...
5 years, 8 months ago (2015-04-03 21:51:33 UTC) #8
sky
LGTM
5 years, 8 months ago (2015-04-03 22:03:12 UTC) #9
sky
SLGTM with the following change https://codereview.chromium.org/1059343002/diff/100001/chrome/browser/sessions/session_restore_stats_collector.cc File chrome/browser/sessions/session_restore_stats_collector.cc (right): https://codereview.chromium.org/1059343002/diff/100001/chrome/browser/sessions/session_restore_stats_collector.cc#newcode174 chrome/browser/sessions/session_restore_stats_collector.cc:174: if (active_only_ && !tab.is_active) ...
5 years, 8 months ago (2015-04-03 22:04:46 UTC) #11
Georges Khalil
On 2015/04/03 22:04:46, sky wrote: > SLGTM with the following change > > https://codereview.chromium.org/1059343002/diff/100001/chrome/browser/sessions/session_restore_stats_collector.cc > ...
5 years, 8 months ago (2015-04-03 22:12:57 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1059343002/120001
5 years, 8 months ago (2015-04-03 22:14:01 UTC) #16
Georges Khalil
PTAnL. Change default behavior when experiment is missing as this was breaking tests. Will tackle ...
5 years, 8 months ago (2015-04-03 23:22:12 UTC) #18
gab
lgtm w/ drive-by nit, given your discussion offline with sky about fixing the tests after ...
5 years, 8 months ago (2015-04-07 12:33:03 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1059343002/200001
5 years, 8 months ago (2015-04-07 13:39:12 UTC) #25
commit-bot: I haz the power
Committed patchset #5 (id:200001)
5 years, 8 months ago (2015-04-07 15:08:38 UTC) #26
commit-bot: I haz the power
5 years, 8 months ago (2015-04-07 15:09:32 UTC) #27
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/fbcd45d1f21b87e0b70111fded7c805db06a43ea
Cr-Commit-Position: refs/heads/master@{#324041}

Powered by Google App Engine
This is Rietveld 408576698