Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1059333004:
simplify branding (Closed)
|
Created:
5 years, 8 months ago by gburanov Modified:
5 years, 7 months ago CC:
chromium-reviews, feature-media-reviews_chromium.org, caitkp+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Descriptionsimplify branding
Please take look at
https://codereview.chromium.org/1090213002/patch/40001/50001
for details
BUG=
Committed: https://crrev.com/be076f940c3d02a690b876095eca988bb49d1930
Cr-Commit-Position: refs/heads/master@{#327270}
Patch Set 1 #Patch Set 2 : try to fix build #Patch Set 3 : Try to fix buils step 2 #Patch Set 4 : It seems the build is finally fixed #Patch Set 5 : add branding path to top variables scope #Patch Set 6 : one more try to fix build #
Messages
Total messages: 36 (17 generated)
Please take a look caitkp@chromium.org robertshield@chromium.org chrome_elf part dalecurtis@chromium.org ddorwin@chromium.org media part scottbyer@chromium.org gene@chromium.org vitalybuka@chromium.org cloud_print part
On 2015/04/24 at 12:32:01, gburanov wrote: > Please take a look > > caitkp@chromium.org > robertshield@chromium.org > chrome_elf part > > > dalecurtis@chromium.org > ddorwin@chromium.org > media part > > scottbyer@chromium.org > gene@chromium.org > vitalybuka@chromium.org > cloud_print part LGTM for cloud print
chrome_elf LGTM
media/ LGTM
The CQ bit was checked by gburanov@gmail.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1059333004/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
The CQ bit was checked by gburanov@gmail.com
The patchset sent to the CQ was uploaded after l-g-t-m from scottbyer@chromium.org, caitkp@chromium.org, ddorwin@chromium.org Link to the patchset: https://codereview.chromium.org/1059333004/#ps20001 (title: "try to fix build")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1059333004/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win8_chromium_rel on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)
The CQ bit was checked by gburanov@gmail.com
The patchset sent to the CQ was uploaded after l-g-t-m from scottbyer@chromium.org, caitkp@chromium.org, ddorwin@chromium.org Link to the patchset: https://codereview.chromium.org/1059333004/#ps40001 (title: "Try to fix buils step 2")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1059333004/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) win8_chromium_rel on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)
The CQ bit was checked by gburanov@gmail.com
The patchset sent to the CQ was uploaded after l-g-t-m from scottbyer@chromium.org, caitkp@chromium.org, ddorwin@chromium.org Link to the patchset: https://codereview.chromium.org/1059333004/#ps60001 (title: "It seems the build is finally fixed")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1059333004/60001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win8_chromium_rel on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)
Sorry for so many tries, but what is wrong with cloud_print/cloud_print_resources.gyp ? Is it not alllowed to set branding_path only once for parent?
On 2015/04/27 at 14:12:29, gburanov wrote: > Sorry for so many tries, but what is wrong with cloud_print/cloud_print_resources.gyp ? > > Is it not alllowed to set branding_path only once for parent? It looks like you're setting branding path on an inner variable scope but not copying it out to the file scope. Sorry I missed that the first time, it's hidden when looking at the unified diff. You need a 'branding_path%': '<(branding_path)' in the same scope as the 'chromium_code': 1 assignment.
The CQ bit was checked by gburanov@gmail.com
The patchset sent to the CQ was uploaded after l-g-t-m from scottbyer@chromium.org, caitkp@chromium.org, ddorwin@chromium.org Link to the patchset: https://codereview.chromium.org/1059333004/#ps80001 (title: "add branding path to top variables scope")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1059333004/80001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by gburanov@gmail.com
The patchset sent to the CQ was uploaded after l-g-t-m from scottbyer@chromium.org, caitkp@chromium.org, ddorwin@chromium.org Link to the patchset: https://codereview.chromium.org/1059333004/#ps100001 (title: "one more try to fix build")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1059333004/100001
Message was sent while issue was closed.
Committed patchset #6 (id:100001)
Message was sent while issue was closed.
Patchset 6 (id:??) landed as https://crrev.com/be076f940c3d02a690b876095eca988bb49d1930 Cr-Commit-Position: refs/heads/master@{#327270} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
