Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1424)

Issue 1059333003: Mac: Fix broken website settings bubble when using Right-to-Left languages. (Closed)

Created:
5 years, 8 months ago by Andre
Modified:
5 years, 8 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@OnWindowWillClose
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mac: Fix broken website settings UI when using Right-to-Left languages. Our NSSegmentedControl customization for this UI never handled RTL layout. The fix is not pretty but it works. BUG=470516 Committed: https://crrev.com/a9a8b90340946bb58a2c9a6448906760f0a31d75 Cr-Commit-Position: refs/heads/master@{#323968}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -17 lines) Patch
M chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller.mm View 3 chunks +25 lines, -17 lines 2 comments Download

Messages

Total messages: 8 (2 generated)
Andre
Robert, PTAL. https://codereview.chromium.org/1059333003/diff/1/chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller.mm File chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller.mm (right): https://codereview.chromium.org/1059333003/diff/1/chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller.mm#newcode231 chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller.mm:231: [self drawInteriorWithFrame:interiorFrame inView:controlView]; Without this fix, the ...
5 years, 8 months ago (2015-04-04 00:17:49 UTC) #2
Robert Sesek
This seems pretty reasonable, really.
5 years, 8 months ago (2015-04-06 21:49:10 UTC) #3
Robert Sesek
And by that I mean LGTM.
5 years, 8 months ago (2015-04-06 21:49:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1059333003/1
5 years, 8 months ago (2015-04-06 21:53:59 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-06 22:37:39 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-04-06 22:39:44 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a9a8b90340946bb58a2c9a6448906760f0a31d75
Cr-Commit-Position: refs/heads/master@{#323968}

Powered by Google App Engine
This is Rietveld 408576698