Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Unified Diff: media/cdm/aes_decryptor.h

Issue 105933004: AesDecryptor callbacks now used in a thread-safe manner (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | media/cdm/aes_decryptor.cc » ('j') | media/cdm/aes_decryptor.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/cdm/aes_decryptor.h
diff --git a/media/cdm/aes_decryptor.h b/media/cdm/aes_decryptor.h
index a72674c102da801ee351a6c0ef44fc65dd10d291..b7354db5546bdf330edfcce8b6e5f5bfc480ad08 100644
--- a/media/cdm/aes_decryptor.h
+++ b/media/cdm/aes_decryptor.h
@@ -135,6 +135,10 @@ class MEDIA_EXPORT AesDecryptor : public MediaKeys, public Decryptor {
NewKeyCB new_audio_key_cb_;
NewKeyCB new_video_key_cb_;
+ // Protect |new_audio_key_cb_| and |new_video_key_cb_| as they are set on the
+ // main thread but called on the compositor thread. http://crbug.com/329530
xhwang 2013/12/19 19:15:44 s/compositor/media/ Since you fixed this bug, no
jrummell 2013/12/19 23:15:40 Done.
+ mutable base::Lock key_cb_lock_;
xhwang 2013/12/19 19:15:44 s/key_cb/new_key_cb/
jrummell 2013/12/19 23:15:40 Done.
+
DISALLOW_COPY_AND_ASSIGN(AesDecryptor);
};
« no previous file with comments | « no previous file | media/cdm/aes_decryptor.cc » ('j') | media/cdm/aes_decryptor.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698