Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 1059323004: Add newly added page or folder last when multiple bookmarks are selected. (Closed)

Created:
5 years, 8 months ago by Deepak
Modified:
5 years, 8 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews, tfarina, noyau+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add newly added page or folder last when multiple bookmarks are selected. When we have more than one items selected then new item should get added in end of list of bookmarks. When we have only one item(Not Folder) selected then new items should get added next to selected item. When we have only folder bookmark selected then new item should get added in last position in the folder. BUG=476500 Committed: https://crrev.com/bc84c2e2dd55b0890c65751b4f37294469893eda Cr-Commit-Position: refs/heads/master@{#324869}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M chrome/browser/resources/bookmark_manager/js/main.js View 2 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Deepak
PTAL for this small change. Thanks
5 years, 8 months ago (2015-04-13 14:43:35 UTC) #2
Bernhard Bauer
Could you please update the CL subject (and first line of the description), so it's ...
5 years, 8 months ago (2015-04-13 15:00:45 UTC) #3
Deepak
On 2015/04/13 15:00:45, Bernhard Bauer wrote: > Could you please update the CL subject (and ...
5 years, 8 months ago (2015-04-13 15:11:14 UTC) #4
Bernhard Bauer
LGTM!
5 years, 8 months ago (2015-04-13 15:21:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1059323004/1
5 years, 8 months ago (2015-04-13 15:22:48 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-13 17:25:55 UTC) #8
commit-bot: I haz the power
5 years, 8 months ago (2015-04-13 17:26:43 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bc84c2e2dd55b0890c65751b4f37294469893eda
Cr-Commit-Position: refs/heads/master@{#324869}

Powered by Google App Engine
This is Rietveld 408576698