Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 1059323003: scheduler: Encapsulate TaskQueueManager inside SchedulerHelper (Closed)

Created:
5 years, 8 months ago by Sami
Modified:
5 years, 8 months ago
CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, jam, scheduler-bugs_chromium.org, mlamouri+watch-content_chromium.org, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

scheduler: Encapsulate TaskQueueManager inside SchedulerHelper Isolate TaskQueueManager inside SchedulerHelper so that classes that embed SchedulerHelper don't end up adding dependencies to TaskQueueManager in a uncontrolled way. No functional changes. Committed: https://crrev.com/f08a17169d8e41d862b5510cf159a513df885730 Cr-Commit-Position: refs/heads/master@{#325235}

Patch Set 1 #

Patch Set 2 : Rebased. #

Patch Set 3 : Rebased. #

Patch Set 4 : GCC build fix. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -32 lines) Patch
M content/child/scheduler/scheduler_helper.h View 1 2 1 chunk +4 lines, -1 line 0 comments Download
M content/child/scheduler/scheduler_helper.cc View 1 2 1 chunk +14 lines, -2 lines 0 comments Download
M content/child/scheduler/scheduler_helper_unittest.cc View 1 2 3 5 chunks +10 lines, -15 lines 0 comments Download
M content/renderer/scheduler/renderer_scheduler_impl.cc View 1 2 4 chunks +6 lines, -14 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
Sami
5 years, 8 months ago (2015-04-13 12:37:20 UTC) #2
rmcilroy
lgtm, thanks!
5 years, 8 months ago (2015-04-13 14:42:55 UTC) #3
alex clarke (OOO till 29th)
I think you'll need to rebase, but it looks good otherwise.
5 years, 8 months ago (2015-04-13 14:44:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1059323003/40001
5 years, 8 months ago (2015-04-15 11:08:55 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_rel_ng/builds/12295)
5 years, 8 months ago (2015-04-15 12:09:39 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1059323003/60001
5 years, 8 months ago (2015-04-15 12:24:03 UTC) #12
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 8 months ago (2015-04-15 13:28:30 UTC) #13
commit-bot: I haz the power
5 years, 8 months ago (2015-04-15 13:29:23 UTC) #14
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/f08a17169d8e41d862b5510cf159a513df885730
Cr-Commit-Position: refs/heads/master@{#325235}

Powered by Google App Engine
This is Rietveld 408576698