net/data/url_request_unittest/hsts-and-hpkp-headers.html.mock-http-headers - Issue 1059303002: Don't process HSTS/HPKP headers when host is an IP address

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/data/url_request_unittest/hsts-and-hpkp-headers.html.mock-http-headers

Issue 1059303002: Don't process HSTS/HPKP headers when host is an IP address (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add tests for HPKP/HSTS headers on IPs Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« net/data/ssl/scripts/generate-test-certs.sh ('K') | « net/data/url_request_unittest/hpkp-headers.html.mock-http-headers ('k') | net/data/url_request_unittest/hsts-and-hpkp-headers2.html.mock-http-headers » ('j') | net/test/spawned_test_server/base_test_server.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: net/data/url_request_unittest/hsts-and-hpkp-headers.html.mock-http-headers

diff --git a/net/data/url_request_unittest/hsts-and-hpkp-headers.html.mock-http-headers b/net/data/url_request_unittest/hsts-and-hpkp-headers.html.mock-http-headers

index 95f923a75ffde82541745c3941d5feb220bc5105..fd04ba6aa55c840bca9d956afdc29a108fcf52b1 100644

--- a/net/data/url_request_unittest/hsts-and-hpkp-headers.html.mock-http-headers

+++ b/net/data/url_request_unittest/hsts-and-hpkp-headers.html.mock-http-headers

@@ -5,4 +5,4 @@ X-Multiple-Entries: a

X-Multiple-Entries: b

Strict-Transport-Security: max-age=12300

Strict-Transport-Security: max-age=12300; includeSubdomains

-Public-Key-Pins: max-age=50000; pin-sha1="Wws2/Z7YhKlX73v3rYHBBxO4OLE="; pin-sha256="2zCMVDKgnKec0721Sp1zVh2yiHeW/LJK4STkNnEa1og="

+Public-Key-Pins: max-age=50000; pin-sha1="Wws2/Z7YhKlX73v3rYHBBxO4OLE="; pin-sha256="99CoGMO/21rgPfRiHJvI6RL3r8/nx3DeVqsqsCXQtRU="