net/test/spawned_test_server/base_test_server.h - Issue 1059303002: Don't process HSTS/HPKP headers when host is an IP address

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/test/spawned_test_server/base_test_server.h

Issue 1059303002: Don't process HSTS/HPKP headers when host is an IP address (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: ugly workaround for mac 10.6 getaddrinfo bug Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « net/data/url_request_unittest/hsts-and-hpkp-headers2.html.mock-http-headers ('k') | net/test/spawned_test_server/base_test_server.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: net/test/spawned_test_server/base_test_server.h

diff --git a/net/test/spawned_test_server/base_test_server.h b/net/test/spawned_test_server/base_test_server.h

index c2d42ee5afd13c3865aa1b51bd96ba185bcbf8ee..5fd57f115405d9e557ce972402b5bc5c24a9ab5b 100644

--- a/net/test/spawned_test_server/base_test_server.h

+++ b/net/test/spawned_test_server/base_test_server.h

@@ -61,6 +61,10 @@ class BaseTestServer {

// TestRootStore) is expected to have a self-signed version of the

// intermediate.

CERT_CHAIN_WRONG_ROOT,

+ // Causes the testserver to use a hostname that is a domain

+ // instead of an IP.

+ CERT_COMMON_NAME_IS_DOMAIN,

};

// OCSPStatus enumerates the types of OCSP response that the testserver