Don't process HSTS/HPKP headers when host is an IP address

chrome/browser/net/websocket_browsertest.cc

Index: chrome/browser/net/websocket_browsertest.cc
diff --git a/chrome/browser/net/websocket_browsertest.cc b/chrome/browser/net/websocket_browsertest.cc
index c96e38b3252c81dcd416205159a7588446999b7c..ed1fa0b9e3ac121467afb107fa09c904fb300cec 100644
--- a/chrome/browser/net/websocket_browsertest.cc
+++ b/chrome/browser/net/websocket_browsertest.cc
@@ -300,20 +300,25 @@ IN_PROC_BROWSER_TEST_F(WebSocketBrowserTest, SSLConnectionLimit) {
 IN_PROC_BROWSER_TEST_F(WebSocketBrowserTest, WebSocketAppliesHSTS) {
   net::SpawnedTestServer https_server(
       net::SpawnedTestServer::TYPE_HTTPS,
-      net::SpawnedTestServer::SSLOptions(),
+      net::SpawnedTestServer::SSLOptions(
+          net::SpawnedTestServer::SSLOptions::CERT_COMMON_NAME_IS_DOMAIN),
       base::FilePath(FILE_PATH_LITERAL("chrome/test/data")));
-  // This test sets HSTS on 127.0.0.1. To avoid being redirected to https, start
-  // the http server on "localhost" instead.
+  net::SpawnedTestServer wss_server(
+      net::SpawnedTestServer::TYPE_WSS,
+      net::SpawnedTestServer::SSLOptions(
+          net::SpawnedTestServer::SSLOptions::CERT_COMMON_NAME_IS_DOMAIN),
+      net::GetWebSocketTestDataDirectory());
+  // This test sets HSTS on localhost. To avoid being redirected to https, start
+  // the http server on 127.0.0.1 instead.
   net::SpawnedTestServer http_server(
-      net::SpawnedTestServer::TYPE_HTTP,
-      "localhost",
+      net::SpawnedTestServer::TYPE_HTTP, net::SpawnedTestServer::kLocalhost,
       base::FilePath(FILE_PATH_LITERAL("chrome/test/data")));
   ASSERT_TRUE(https_server.StartInBackground());
   ASSERT_TRUE(http_server.StartInBackground());
-  ASSERT_TRUE(wss_server_.StartInBackground());
+  ASSERT_TRUE(wss_server.StartInBackground());
   ASSERT_TRUE(https_server.BlockUntilStarted());
 
-  // Set HSTS on 127.0.0.1.
+  // Set HSTS on localhost.
   content::TitleWatcher title_watcher(
       browser()->tab_strip_model()->GetActiveWebContents(),
       base::ASCIIToUTF16("SET"));
@@ -323,8 +328,8 @@ IN_PROC_BROWSER_TEST_F(WebSocketBrowserTest, WebSocketAppliesHSTS) {
   EXPECT_TRUE(EqualsASCII(result, "SET"));
 
   // Verify that it applies to WebSockets.
-  ASSERT_TRUE(wss_server_.BlockUntilStarted());
-  GURL wss_url = wss_server_.GetURL("echo-with-no-extension");
+  ASSERT_TRUE(wss_server.BlockUntilStarted());
+  GURL wss_url = wss_server.GetURL("echo-with-no-extension");
   std::string scheme("ws");
   GURL::Replacements scheme_replacement;
   scheme_replacement.SetSchemeStr(scheme);