[strong] Implement static restrictions on direct eval

test/mjsunit/strong/classes.js

Index: test/mjsunit/strong/classes.js
diff --git a/test/mjsunit/strong/classes.js b/test/mjsunit/strong/classes.js
index e33742af3fbd6373f68ac69b073e5b47a15c72d4..26c4fd5256b11b6ff577384fc0f504787ffdaa5a 100644
--- a/test/mjsunit/strong/classes.js
+++ b/test/mjsunit/strong/classes.js
@@ -9,18 +9,21 @@
 
 class C {}
 
+let ind_eval = eval;
+
 function assertTypeError(script) { assertThrows(script, TypeError) }
 function assertSyntaxError(script) { assertThrows(script, SyntaxError) }
 function assertReferenceError(script) { assertThrows(script, ReferenceError) }
 
 (function ImmutableClassBindings() {
   class D {}
-  assertTypeError(function(){ eval("C = 0") });
-  assertTypeError(function(){ eval("D = 0") });

[arv (Not doing code reviews), 2015/04/13 14:14:06]

This can be written as:

assertTypeError(function(){
  D = 0;
});

Which is much cleaner than the test with eval you added on line 25. 

[conradw, 2015/04/13 14:36:33]

Unfortunately this assignment will be an early error in strong mode (once we
implement it!) and would prevent the entire test script from executing. We need
a test that checks that assignment to the identifier of a locally scoped class
is disallowed, but avoiding the early error requires some sort of "eval"
containment.

+  assertTypeError(function(){ ind_eval("C = 0") });
   assertEquals('function', typeof C);
   assertEquals('function', typeof D);
 })();
 
+assertTypeError("'use strong'; (function f() {class E {}; E = 0})()");
+
 function constructor(body) {
   return "'use strong'; " +
       "(class extends Object { constructor() { " + body + " } })";