src/preparser.h - Issue 1059273004: [strong] Implement static restrictions on direct eval

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/preparser.h

Issue 1059273004: [strong] Implement static restrictions on direct eval (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: cr feedback Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/preparser.h

diff --git a/src/preparser.h b/src/preparser.h

index 0b00f819abe1f1bcc0543c7f823b8981ee3a2cfb..219fe2de5a0d2abcca6e416027bdf9d63d6c6a1a 100644

--- a/src/preparser.h

+++ b/src/preparser.h

@@ -2804,6 +2804,12 @@ ParserBase<Traits>::ParseLeftHandSideExpression(bool* ok) {

}

case Token::LPAREN: {

+ if (is_strong(language_mode()) && this->IsIdentifier(result) &&

+ this->IsEval(this->AsIdentifier(result))) {

+ ReportMessage("strong_direct_eval");

+ *ok = false;

+ return this->EmptyExpression();

+ }

int pos;

if (scanner()->current_token() == Token::IDENTIFIER) {

// For call of an identifier we want to report position of