Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 1059233004: Init Mojo embedder for Windows NaCl plugins. (Closed)

Created:
5 years, 8 months ago by teravest
Modified:
5 years, 8 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Init Mojo embedder for Windows NaCl plugins. With this change (and another fix for NACL_BUILD_SUBARCH), we can test Pepper/Mojo/NaCl support on Windows. This also moves embedder initialization to nacl_helper for clarity: The Mojo embedder must be initialized in nacl_helper when that process is used. When the plugin is running in a chrome process, ContentMain() handles Mojo embedder initialization. This change doesn't enable the test MojoFailsWithoutFlag on Windows, since the abort() triggers a dialog that causes the test to time out. BUG=414804 R=dmichael@chromium.org, ncbray@chromium.org Committed: https://crrev.com/e30c97ba8d11ad3d6048dcc6167cbfcb7cf9d49f Cr-Commit-Position: refs/heads/master@{#323908}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -18 lines) Patch
M chrome/test/ppapi/ppapi_browsertest.cc View 1 chunk +8 lines, -8 lines 0 comments Download
M components/nacl.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M components/nacl/loader/nacl_helper_linux.cc View 2 chunks +11 lines, -0 lines 0 comments Download
M components/nacl/loader/nacl_helper_win_64.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M components/nacl/loader/nacl_listener.cc View 2 chunks +0 lines, -10 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
teravest
Resending this patch with MojoFailsWithoutFlag disabled on Windows. The abort() in the disabled Mojo interface ...
5 years, 8 months ago (2015-04-03 19:52:40 UTC) #1
dmichael (off chromium)
FYI It's usually a good idea to either reuse the original CL or at least ...
5 years, 8 months ago (2015-04-03 19:55:32 UTC) #2
Nick Bray (chromium)
LGTM
5 years, 8 months ago (2015-04-03 22:56:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1059233004/1
5 years, 8 months ago (2015-04-06 15:22:30 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-06 16:11:34 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-06 17:36:17 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e30c97ba8d11ad3d6048dcc6167cbfcb7cf9d49f
Cr-Commit-Position: refs/heads/master@{#323908}

Powered by Google App Engine
This is Rietveld 408576698