Source/core/workers/WorkerGlobalScope.cpp - Issue 1059193002: Add UMA to understand the typical total size of ServiceWorker script [1/2 blink]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/workers/WorkerGlobalScope.cpp

Issue 1059193002: Add UMA to understand the typical total size of ServiceWorker script [1/2 blink] (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/core/workers/WorkerGlobalScope.h ('k') | Source/core/workers/WorkerThread.cpp » ('j') | Source/modules/serviceworkers/ServiceWorkerGlobalScope.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/workers/WorkerGlobalScope.cpp

diff --git a/Source/core/workers/WorkerGlobalScope.cpp b/Source/core/workers/WorkerGlobalScope.cpp

index dbadaf3aee98e156b5f74be984bdcb6fd41c3c28..b67a103fa0d5e4147f9ad33642f34393e66827d2 100644

--- a/Source/core/workers/WorkerGlobalScope.cpp

+++ b/Source/core/workers/WorkerGlobalScope.cpp

@@ -268,6 +268,7 @@ void WorkerGlobalScope::importScripts(const Vector<String>& urls, ExceptionState

}

InspectorInstrumentation::scriptImported(&executionContext, scriptLoader->identifier(), scriptLoader->script());

+ scriptLoaded(scriptLoader->script().length(), scriptLoader->cachedMetadata() ? scriptLoader->cachedMetadata()->size() : 0);

RefPtrWillBeRawPtr<ErrorEvent> errorEvent = nullptr;

OwnPtr<Vector<char>> cachedMetaData(scriptLoader->releaseCachedMetadata());