Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 1059193002: Add UMA to understand the typical total size of ServiceWorker script [1/2 blink] (Closed)

Created:
5 years, 8 months ago by horo
Modified:
5 years, 8 months ago
CC:
blink-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, nhiroki, falken, kinuko+serviceworker, kinuko+worker_chromium.org, horo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Add UMA to understand the typical total size of ServiceWorker script [1/2 blink] This cl introduces three UMAs. - ServiceWorker.ScriptCount - ServiceWorker.ScriptTotalSize - ServiceWorker.ScriptCachedMetadataTotalSize 1/2 blink: This cl. 2/2 chromium: https://codereview.chromium.org/1055423002/ BUG=408451 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193104

Patch Set 1 #

Total comments: 2

Patch Set 2 : check Platform::current() #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -3 lines) Patch
M Source/core/workers/WorkerGlobalScope.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/workers/WorkerGlobalScope.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/workers/WorkerThread.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerGlobalScope.h View 2 chunks +7 lines, -3 lines 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerGlobalScope.cpp View 1 4 chunks +17 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
horo
ksakamoto@ Could you please review this?
5 years, 8 months ago (2015-04-03 08:33:58 UTC) #2
Kunihiko Sakamoto
lgtm
5 years, 8 months ago (2015-04-03 09:10:00 UTC) #3
horo
haraken@ Could you please review this?
5 years, 8 months ago (2015-04-03 09:12:41 UTC) #5
haraken
LGTM https://codereview.chromium.org/1059193002/diff/1/Source/modules/serviceworkers/ServiceWorkerGlobalScope.cpp File Source/modules/serviceworkers/ServiceWorkerGlobalScope.cpp (right): https://codereview.chromium.org/1059193002/diff/1/Source/modules/serviceworkers/ServiceWorkerGlobalScope.cpp#newcode110 Source/modules/serviceworkers/ServiceWorkerGlobalScope.cpp:110: Platform::current()->histogramCustomCounts("ServiceWorker.ScriptCount", m_scriptCount, 1, 1000, 50); Do we probably ...
5 years, 8 months ago (2015-04-03 09:16:53 UTC) #6
horo
Thank you! https://codereview.chromium.org/1059193002/diff/1/Source/modules/serviceworkers/ServiceWorkerGlobalScope.cpp File Source/modules/serviceworkers/ServiceWorkerGlobalScope.cpp (right): https://codereview.chromium.org/1059193002/diff/1/Source/modules/serviceworkers/ServiceWorkerGlobalScope.cpp#newcode110 Source/modules/serviceworkers/ServiceWorkerGlobalScope.cpp:110: Platform::current()->histogramCustomCounts("ServiceWorker.ScriptCount", m_scriptCount, 1, 1000, 50); On 2015/04/03 ...
5 years, 8 months ago (2015-04-03 09:27:01 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1059193002/20001
5 years, 8 months ago (2015-04-03 10:42:34 UTC) #10
commit-bot: I haz the power
5 years, 8 months ago (2015-04-03 11:06:57 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=193104

Powered by Google App Engine
This is Rietveld 408576698