Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 1059183004: [BackgroundSyncManager] Remove dead code (Closed)

Created:
5 years, 8 months ago by jkarlin
Modified:
5 years, 8 months ago
Reviewers:
jsbell
CC:
chromium-reviews, tim+watch_chromium.org, zea+watch_chromium.org, maxbogue+watch_chromium.org, jam, pvalenzuela+watch_chromium.org, plaree+watch_chromium.org, jkarlin+watch_chromium.org, darin-cc_chromium.org, maniscalco+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused parameter. Committed: https://crrev.com/0a76becb3c8bc0dce4a6b05a1c3b7a1c42053d1d Cr-Commit-Position: refs/heads/master@{#324141}

Patch Set 1 #

Patch Set 2 : Remove moar! #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -19 lines) Patch
M content/browser/background_sync/background_sync_manager.h View 1 2 chunks +2 lines, -5 lines 0 comments Download
M content/browser/background_sync/background_sync_manager.cc View 1 2 chunks +4 lines, -14 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
jkarlin
jsbell: Please review all. Thanks!
5 years, 8 months ago (2015-04-07 19:03:00 UTC) #2
jsbell
lgtm Are there plans for future callers to RemoveRegistrationFromMap() to use the old_registration param, or ...
5 years, 8 months ago (2015-04-07 20:05:49 UTC) #3
jkarlin
Removed that too, PTAL!
5 years, 8 months ago (2015-04-07 20:43:50 UTC) #4
jsbell
Still lgtm
5 years, 8 months ago (2015-04-07 20:59:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1059183004/20001
5 years, 8 months ago (2015-04-07 21:14:21 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-07 22:53:41 UTC) #8
commit-bot: I haz the power
5 years, 8 months ago (2015-04-07 22:54:38 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0a76becb3c8bc0dce4a6b05a1c3b7a1c42053d1d
Cr-Commit-Position: refs/heads/master@{#324141}

Powered by Google App Engine
This is Rietveld 408576698