Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2006)

Unified Diff: Source/modules/websockets/DOMWebSocket.cpp

Issue 1059183003: Use enum BinaryType for WebSocket.binaryType, instead of DOMString (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/websockets/DOMWebSocket.cpp
diff --git a/Source/modules/websockets/DOMWebSocket.cpp b/Source/modules/websockets/DOMWebSocket.cpp
index f32af360759292e8554c232d44a334f5f5820ef0..ccf4d7f38900365194522e4dd85763a6fac176e1 100644
--- a/Source/modules/websockets/DOMWebSocket.cpp
+++ b/Source/modules/websockets/DOMWebSocket.cpp
@@ -552,7 +552,7 @@ void DOMWebSocket::setBinaryType(const String& binaryType)
m_binaryType = BinaryTypeArrayBuffer;
return;
}
- logError("'" + binaryType + "' is not a valid value for binaryType; binaryType remains unchanged.");
+ ASSERT_NOT_REACHED();
}
const AtomicString& DOMWebSocket::interfaceName() const
« no previous file with comments | « LayoutTests/http/tests/websocket/binary-type-expected.txt ('k') | Source/modules/websockets/DOMWebSocketTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698