Issue 1059183003: Use enum BinaryType for WebSocket.binaryType, instead of DOMString

Issue 1059183003: Use enum BinaryType for WebSocket.binaryType, instead of DOMString (Closed)

Created:
5 years, 8 months ago by Paritosh Kumar

Modified:
5 years, 8 months ago

Reviewers:
Nils Barth (inactive), tyoshino (SeeGerritForStatus), jsbell

CC:
blink-reviews

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

Re-submit of http://crrev.com/871013007/ As Death Test was failing (see http://crrev.com/1053013006/), remove Death Test from DOMWebSocketTest, otherwise identical. R=nbarth,jsbell TBR=tyoshino Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193282

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+5 lines, -14 lines)			Patch
M	LayoutTests/http/tests/websocket/binary-type-expected.txt	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	Source/modules/websockets/DOMWebSocket.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/modules/websockets/DOMWebSocketTest.cpp	View	1 chunk	+0 lines, -8 lines	0 comments	Download
M	Source/modules/websockets/WebSocket.idl	View	2 chunks	+1 line, -2 lines	0 comments	Download

Total messages: 8 (2 generated)

Paritosh Kumar

As per Nils comment on https://codereview.chromium.org/871013007/ uploaded this CL without DEATH Tests. Please have a ...

5 years, 8 months ago (2015-04-07 05:31:40 UTC) #2

jsbell

I added TBR=tyoshino as this is just a re-submit. Let's get this in!

5 years, 8 months ago (2015-04-07 15:47:35 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1059183003/1

5 years, 8 months ago (2015-04-07 15:48:00 UTC) #7

commit-bot: I haz the power

5 years, 8 months ago (2015-04-07 17:07:25 UTC) #8

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=193282