Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Issue 1059163003: Revert of Re-enabling 720p webcam test for QTKit on Mac. (Closed)

Created:
5 years, 8 months ago by tommi (sloooow) - chröme
Modified:
5 years, 8 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, feature-media-reviews_chromium.org, wjia+watch_chromium.org, mcasas+watch_chromium.org, mcasas
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Re-enabling 720p webcam test for QTKit on Mac. (patchset #1 id:1 of https://codereview.chromium.org/1039163002/) Reason for revert: Doesn't look fixed. This has been consistently failing since landing, here: https://build.chromium.org/p/chromium.webrtc/builders/Mac%20Tester?numbuilds=200 Original issue's description: > Re-enabling 720p webcam test for QTKit on Mac. > > mcasas tested it and it appears to work now. > > BUG=440762 > > Committed: https://crrev.com/6ad0306bf6039949bf7a572b07a839a3e6cd1ebb > Cr-Commit-Position: refs/heads/master@{#322572} TBR=perkj@chromium.org,phoglund@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=440762 Committed: https://crrev.com/66ef8c7075c1532db8cf1bb9c20e31eb63331f4c Cr-Commit-Position: refs/heads/master@{#323794}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M chrome/browser/media/chrome_webrtc_webcam_browsertest.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
tommi (sloooow) - chröme
Created Revert of Re-enabling 720p webcam test for QTKit on Mac.
5 years, 8 months ago (2015-04-03 19:29:23 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1059163003/1
5 years, 8 months ago (2015-04-03 19:29:53 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-03 19:30:53 UTC) #3
commit-bot: I haz the power
5 years, 8 months ago (2015-04-03 20:40:03 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/66ef8c7075c1532db8cf1bb9c20e31eb63331f4c
Cr-Commit-Position: refs/heads/master@{#323794}

Powered by Google App Engine
This is Rietveld 408576698