Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(467)

Issue 1059153002: Run tools/metrics/histograms/update_use_counter_feature_enum.py (Closed)

Created:
5 years, 8 months ago by kochi
Modified:
5 years, 8 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org, dcheng, adamk
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Run tools/metrics/histograms/update_use_counter_feature_enum.py This is for https://codereview.chromium.org/1058723004/ in Blink, to add "tabStop" property/attribute stats. BUG=380445 TBR=isherman Committed: https://crrev.com/bc51757ce5fb17ef5fc0f5eb3cab589d7c0dcdef Cr-Commit-Position: refs/heads/master@{#323890}

Patch Set 1 #

Patch Set 2 : renumber #

Patch Set 3 : renumber, the previous number was reverted #

Patch Set 4 : rebase and update (LegacyConst) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M tools/metrics/histograms/histograms.xml View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
kochi
Could you review this?
5 years, 8 months ago (2015-04-03 04:42:33 UTC) #2
kochi
On 2015/04/03 04:42:33, Takayoshi Kochi wrote: > Could you review this? Oops, some other CL ...
5 years, 8 months ago (2015-04-03 04:55:57 UTC) #3
kochi
+cc dcheng FYI, for DocumentURI counter.
5 years, 8 months ago (2015-04-03 04:57:08 UTC) #4
Ilya Sherman
LGTM
5 years, 8 months ago (2015-04-03 18:35:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1059153002/40001
5 years, 8 months ago (2015-04-05 16:38:28 UTC) #7
kochi
I noticed yet another counter is added (748:LegacyConst). Cc'ing adamk@ and TBR'ing for the addition.
5 years, 8 months ago (2015-04-06 01:51:39 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1059153002/60001
5 years, 8 months ago (2015-04-06 01:51:48 UTC) #12
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 8 months ago (2015-04-06 03:05:39 UTC) #13
commit-bot: I haz the power
5 years, 8 months ago (2015-04-06 03:06:26 UTC) #14
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/bc51757ce5fb17ef5fc0f5eb3cab589d7c0dcdef
Cr-Commit-Position: refs/heads/master@{#323890}

Powered by Google App Engine
This is Rietveld 408576698