Issue 1059103003: Guards irrelevant targets for Cast Android build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1059103003: Guards irrelevant targets for Cast Android build. (Closed)

Created:
5 years, 8 months ago by gunsch

Modified:
5 years, 8 months ago

Reviewers:
cjhopman

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Guards irrelevant targets for Cast Android build. This allows building "All" to be more sensible with this GYP set: chromecast=1 OS=android R=cjhopman@chromium.org BUG=472823 Committed: https://crrev.com/126525e3197bc40568d847575a4ad0486cae55bf Cr-Commit-Position: refs/heads/master@{#323775}

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -16 lines)			Patch
	M	build/all.gyp	View		6 chunks	+25 lines, -16 lines	0 comments	Download

Total messages: 8 (2 generated)

gunsch

-scottmg, +cjhopman looks like scottmg@ and thakis@ are both OOO

5 years, 8 months ago (2015-04-03 16:58:00 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1059103003/1

5 years, 8 months ago (2015-04-03 17:19:17 UTC) #6

commit-bot: I haz the power

5 years, 8 months ago (2015-04-03 20:39:09 UTC) #8

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/126525e3197bc40568d847575a4ad0486cae55bf
Cr-Commit-Position: refs/heads/master@{#323775}