Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 1059093003: Fix password manager subframe test to watch for navigation in subframe. (Closed)

Created:
5 years, 8 months ago by dcheng
Modified:
5 years, 8 months ago
Reviewers:
Garrett Casto
CC:
chromium-reviews, gcasto+watchlist_chromium.org, mkwst+watchlist-passwords_chromium.org, Nate Chapin
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix password manager subframe test to watch for navigation in subframe. It looks like the intent of this test is to make sure that the password prompt doesn't show up for a failed login in a subframe. However, the test is a bit odd: it races the form submit and navigation of the main frame. Presumably, this was done so NavigationObserver can wait for the top-level navigation of the page and observer success/failure of the test conditions. Since NavigationObserver can wait for subframes to load, just fix the test to wait for the subframe to commit. BUG=464764 Committed: https://crrev.com/aa719a69b0fade8bd70e31886ac0dbf09cb9f0ce Cr-Commit-Position: refs/heads/master@{#323951}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/password_manager/password_manager_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
dcheng
The test JS is a bit odd, since it submits a subframe and navigates the ...
5 years, 8 months ago (2015-04-04 13:48:49 UTC) #2
Garrett Casto
lgtm
5 years, 8 months ago (2015-04-06 20:28:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1059093003/1
5 years, 8 months ago (2015-04-06 20:32:47 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-06 21:10:57 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-06 21:12:40 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/aa719a69b0fade8bd70e31886ac0dbf09cb9f0ce
Cr-Commit-Position: refs/heads/master@{#323951}

Powered by Google App Engine
This is Rietveld 408576698