Loads CastEglPlatform implementation from shared library.

chromecast/public/cast_egl_platform.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#ifndef CHROMECAST_OZONE_CAST_EGL_PLATFORM_H_
-#define CHROMECAST_OZONE_CAST_EGL_PLATFORM_H_
+#ifndef CHROMECAST_PUBLIC_CAST_EGL_PLATFORM_H_
+#define CHROMECAST_PUBLIC_CAST_EGL_PLATFORM_H_
 
 #include "ui/ozone/public/surface_factory_ozone.h"
 
 namespace gfx {
 class Size;
 }
 
 namespace chromecast {
-namespace ozone {
 
 // Interface representing all the hardware-specific elements of an Ozone
 // implementation for Cast.  Supply an implementation of this interface
 // to OzonePlatformCast to create a complete Ozone implementation.
 class CastEglPlatform {
  public:
   typedef ui::SurfaceFactoryOzone::AddGLLibraryCallback AddGLLibraryCallback;
   typedef ui::SurfaceFactoryOzone::SetGLGetProcAddressProcCallback

[gunsch, 2015/04/02 22:44:36]

A thought: these typedefs seem to be the only dependency on SurfaceFactoryOzone.
Could/should we re-define them here explicitly to avoid any Chromium
dependencies from the shlib?

[halliwell, 2015/04/02 22:50:07]

Yes, I think that would be good - although note it won't quite eliminate all
Chromium dependencies, it will replace this with dependencies on base::Callback
and base::NativeLibrary (which these these typedefs use).

[gunsch, 2015/04/02 22:56:47]

I was thinking more along the lines of potentially adapting the base::Callback
to a function-pointer. base::NativeLibrary is just a void* for OS_POSIX.

       SetGLGetProcAddressProcCallback;
 
   virtual ~CastEglPlatform() {}
 
   // Default display size is used for initial display and also as a minimum
   // resolution for applications.
   virtual gfx::Size GetDefaultDisplaySize() const = 0;
 
   // Returns an array of EGL properties, which can be used in any EGL function
   // used to select a display configuration. Note that all properties should be
@@ skipping 22 matching lines @@
   virtual intptr_t CreateDisplayType(const gfx::Size& size) = 0;
   virtual void DestroyDisplayType(intptr_t display_type) = 0;
 
   // Create/destroy an EGLNativeWindow.  There will be at most one window at a
   // time, created within a valid display type.
   virtual intptr_t CreateWindow(intptr_t display_type,
                                 const gfx::Size& size) = 0;
   virtual void DestroyWindow(intptr_t window) = 0;
 };
 
-}  // namespace ozone
 }  // namespace chromecast
 
-#endif  // CHROMECAST_OZONE_CAST_EGL_PLATFORM_H_
+#endif  // CHROMECAST_PUBLIC_CAST_EGL_PLATFORM_H_