Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1349)

Unified Diff: chrome/browser/extensions/api/networking_private/networking_private_apitest.cc

Issue 1059033002: Implement networkingPrivate.getDeviceStates (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix test Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/networking_private/networking_private_apitest.cc
diff --git a/chrome/browser/extensions/api/networking_private/networking_private_apitest.cc b/chrome/browser/extensions/api/networking_private/networking_private_apitest.cc
index 8d7b2665020c45b0354aee7fde78d7061bb76dfb..6a3a503df017448026d75b70275e478a21e73dce 100644
--- a/chrome/browser/extensions/api/networking_private/networking_private_apitest.cc
+++ b/chrome/browser/extensions/api/networking_private/networking_private_apitest.cc
@@ -146,6 +146,19 @@ class TestDelegate : public NetworkingPrivateDelegate {
return result.Pass();
}
+ scoped_ptr<DeviceStateList> GetDeviceStateList() override {
+ scoped_ptr<DeviceStateList> result;
+ if (fail_)
+ return result.Pass();
+ result.reset(new DeviceStateList);
+ scoped_ptr<core_api::networking_private::DeviceStateProperties> properties(
+ new core_api::networking_private::DeviceStateProperties);
+ properties->type = core_api::networking_private::NETWORK_TYPE_ETHERNET;
+ properties->state = core_api::networking_private::DEVICE_STATE_TYPE_ENABLED;
+ result->push_back(properties.Pass());
+ return result.Pass();
+ }
+
bool EnableNetworkType(const std::string& type) override {
enabled_[type] = true;
return !fail_;
@@ -362,6 +375,10 @@ IN_PROC_BROWSER_TEST_F(NetworkingPrivateApiTest, GetEnabledNetworkTypes) {
EXPECT_TRUE(RunNetworkingSubtest("getEnabledNetworkTypes")) << message_;
}
+IN_PROC_BROWSER_TEST_F(NetworkingPrivateApiTest, GetDeviceStates) {
+ EXPECT_TRUE(RunNetworkingSubtest("getDeviceStates")) << message_;
+}
+
IN_PROC_BROWSER_TEST_F(NetworkingPrivateApiTest, EnableNetworkType) {
EXPECT_TRUE(RunNetworkingSubtest("enableNetworkType")) << message_;
EXPECT_TRUE(GetEnabled(::onc::network_config::kEthernet));
@@ -459,6 +476,10 @@ IN_PROC_BROWSER_TEST_F(NetworkingPrivateApiTestFail, GetEnabledNetworkTypes) {
EXPECT_FALSE(RunNetworkingSubtest("getEnabledNetworkTypes")) << message_;
}
+IN_PROC_BROWSER_TEST_F(NetworkingPrivateApiTestFail, GetDeviceStates) {
+ EXPECT_FALSE(RunNetworkingSubtest("getDeviceStates")) << message_;
+}
+
// Note: Synchronous methods never fail:
// * disableNetworkType
// * enableNetworkType

Powered by Google App Engine
This is Rietveld 408576698