Implement networkingPrivate.getDeviceStates

chrome/test/data/extensions/api_test/networking_private/chromeos/test.js

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // The expectations in this test for the Chrome OS implementation. See
 // networking_private_chromeos_apitest.cc for more info.
 
 var callbackPass = chrome.test.callbackPass;
 var callbackFail = chrome.test.callbackFail;
 var assertTrue = chrome.test.assertTrue;
@@ skipping 322 matching lines @@
           Name: 'wifi2_PSK',
           Source: 'User',
           Type: NetworkType.WiFi,
           WiFi: {
             Security: 'WPA-PSK',
             SignalStrength: 80
           }
         }], result);
       }));
   },
+  function getDeviceStates() {
+    chrome.networkingPrivate.getDeviceStates(callbackPass(function(result) {
+      assertEq([
+        {Scanning: false, State: 'Enabled', Type: 'WiFi'},
+        {State: 'Uninitialized', Type: 'Cellular'},
+        {State: 'Enabled', Type: 'Ethernet'},

[pneubeck (no reviews), 2015/04/09 09:41:21]

you documentation of the API states that this should include a 'Scanning'
property. Probably you want to update the documentation.

[stevenjb, 2015/04/09 16:20:24]

Actually, this is a bug in the fake implementation; no Ethernet device was being
added. (Even though Scanning will always be false for Ethernet, it seems simpler
to just provide it). Fixed.

+        {State: 'Disabled', Type: 'WiMAX'},
+      ],
+               result);
+    }));
+  },
   function requestNetworkScan() {
     // Connected or Connecting networks should be listed first, sorted by type.
     var expected = ['stub_ethernet_guid',
                     'stub_wifi1_guid',
                     'stub_wimax_guid',
                     'stub_vpn1_guid',
                     'stub_vpn2_guid',
                     'stub_wifi2_guid'];
     var done = chrome.test.callbackAdded();
     var listener = new privateHelpers.listListener(expected, done);
@@ skipping 256 matching lines @@
                     'stub_vpn1_guid',
                     'stub_wifi1_guid',
                     'stub_vpn2_guid'];
     var done = chrome.test.callbackAdded();
     var listener = new privateHelpers.listListener(expected, done);
     chrome.networkingPrivate.onNetworkListChanged.addListener(
       listener.listenForChanges);
     var network = 'stub_wifi2_guid';
     chrome.networkingPrivate.startConnect(network, callbackPass());
   },
+  function onDeviceStateListChangedEvent() {
+    console.log('onDeviceStateListChangedEvent');

[pneubeck (no reviews), 2015/04/09 09:41:21]

nit: remove

[stevenjb, 2015/04/09 16:20:24]

Done.

+    var done = chrome.test.callbackAdded();
+    var listener = function() {

[pneubeck (no reviews), 2015/04/09 09:41:21]

instead of using callbackAdded, you can wrap the listener into callbackPass(),
as it's a onetime listener.

[stevenjb, 2015/04/09 16:20:25]

Done.

+      chrome.networkingPrivate.onDeviceStateListChanged.removeListener(
+          listener);
+      done();

[pneubeck (no reviews), 2015/04/09 09:41:21]

not sure if that makes sense with the stub implementations: you could
additionally verify whether WiFi is actually disabled

[stevenjb, 2015/04/09 16:20:25]

I'd just as soon not test behavior that isn't directly tied to this test, it
adds confusion if disableNetworkType breaks in the fake implementation.

That said, we don't currently test enable/disableNetworkTye, so I added a
separate test for those.

+    };
+    chrome.networkingPrivate.onDeviceStateListChanged.addListener(listener);
+    chrome.networkingPrivate.disableNetworkType('WiFi');
+  },
   function verifyDestination() {
     chrome.networkingPrivate.verifyDestination(
       verificationProperties,
       callbackPass(function(isValid) {
         assertTrue(isValid);
       }));
   },
   function verifyAndEncryptCredentials() {
     var network_guid = 'stub_wifi2_guid';
     chrome.networkingPrivate.verifyAndEncryptCredentials(
@@ skipping 45 matching lines @@
         new privateHelpers.watchForCaptivePortalState(
             'wifi_guid', 'Online', done);
     chrome.test.sendMessage('notifyPortalDetectorObservers');
   },
 ];
 
 var testToRun = window.location.search.substring(1);
 chrome.test.runTests(availableTests.filter(function(op) {
   return op.name == testToRun;
 }));