Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 1059023003: Update DEPS to pull V8 from the new repository. (Closed)

Created:
5 years, 8 months ago by Tom Sepez
Modified:
5 years, 8 months ago
Reviewers:
Lei Zhang, brucedawson
CC:
pdfium-reviews_googlegroups.com, brucedawson
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Update DEPS to pull V8 from the new repository. Also update build files to deal with the new revision. The main issue is the external startup files for v8. The default is not to use them (simpler for standalone users to deploy), but can be built either way. R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/ea18d0b4bdb7e993f3c78b83493e3dac9acc4a44

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -5 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M build/standalone.gypi View 4 chunks +9 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Tom Sepez
+Lei, for review. +Bruce, FYI.
5 years, 8 months ago (2015-04-09 19:02:14 UTC) #2
Lei Zhang
lgtm
5 years, 8 months ago (2015-04-09 21:03:18 UTC) #3
Tom Sepez
Committed patchset #1 (id:1) manually as ea18d0b4bdb7e993f3c78b83493e3dac9acc4a44 (presubmit successful).
5 years, 8 months ago (2015-04-09 21:05:41 UTC) #4
brucedawson
5 years, 8 months ago (2015-04-09 21:12:56 UTC) #6
Message was sent while issue was closed.
lgtm

With this change I get the necessary v8 fixes and I can then build with VS 2015
with just some simple standalone.gypi changes.

Powered by Google App Engine
This is Rietveld 408576698