Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(417)

Issue 1058983002: Revert of cc: Trigger BeginImplFrameDeadline immediately when invisible. (Closed)

Created:
5 years, 8 months ago by tommycli
Modified:
5 years, 8 months ago
CC:
chromium-reviews, cc-bugs_chromium.org, scheduler-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of cc: Trigger BeginImplFrameDeadline immediately when invisible. (patchset #1 id:1 of https://codereview.chromium.org/1051123002/) Reason for revert: Speculative revert to fix persistent WebViewTest.Shim_TestAutosizeWithPartialAttributes breakage. See http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests/builds/22760 Original issue's description: > cc: Trigger BeginImplFrameDeadline immediately when invisible. > > When becoming invisible we are going to abort any pending draw / activate. We > should do that right now rather then waking up sometime in the future and doing > it. This increases the speed at which we become idle after going invisible. > > A minor side effect is we will do more work if we become invisible and then > visible within a single frame, but this case is extremely unlikely while the > case compared to becoming invisible for a longer period. > > Related to http://crrev.com/1050833002 > > BUG=371747 > R=brianderson,jdduke TBR=brianderson@chromium.org,jdduke@chromium.org,mithro@mithis.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=371747 Committed: https://crrev.com/fe201d68f97d395c920fe173ccdb9189936acc76 Cr-Commit-Position: refs/heads/master@{#323545}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -22 lines) Patch
M cc/scheduler/scheduler_state_machine.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M cc/scheduler/scheduler_state_machine_unittest.cc View 1 chunk +0 lines, -19 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
tommycli
Created Revert of cc: Trigger BeginImplFrameDeadline immediately when invisible.
5 years, 8 months ago (2015-04-02 18:44:40 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1058983002/1
5 years, 8 months ago (2015-04-02 18:45:23 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-02 18:52:02 UTC) #3
commit-bot: I haz the power
5 years, 8 months ago (2015-04-03 20:28:17 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fe201d68f97d395c920fe173ccdb9189936acc76
Cr-Commit-Position: refs/heads/master@{#323545}

Powered by Google App Engine
This is Rietveld 408576698