chromeos/network/onc/onc_signature.cc - Issue 1058973002: Add an ONC property for disabling LCP echo

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromeos/network/onc/onc_signature.cc

Issue 1058973002: Add an ONC property for disabling LCP echo (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Typo "Enabled" instead of "Disabled" Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chromeos/network/onc/onc_signature.cc

diff --git a/chromeos/network/onc/onc_signature.cc b/chromeos/network/onc/onc_signature.cc

index b001afe96af0e0836157b4e0a797f85c07da72e1..4137c64ab1e7b02888b592ab84f352c84a9e2063 100644

--- a/chromeos/network/onc/onc_signature.cc

+++ b/chromeos/network/onc/onc_signature.cc

@@ -98,6 +98,7 @@ const OncFieldSignature l2tp_fields[] = {

{::onc::vpn::kPassword, &kStringSignature},

{::onc::vpn::kSaveCredentials, &kBoolSignature},

{::onc::vpn::kUsername, &kStringSignature},

stevenjb 2015/04/03 23:45:31 nit: while we are in here we should really add Pas

+ {::onc::l2tp::kLcpEchoDisabled, &kBoolSignature},

{NULL}};

const OncFieldSignature openvpn_fields[] = {