Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 105893015: Update third_party/nss to NSS 3.15.4. (Closed)

Created:
6 years, 11 months ago by wtc
Modified:
6 years, 11 months ago
Reviewers:
agl, Ryan Sleevi
CC:
chromium-reviews
Visibility:
Public.

Description

Update third_party/nss to NSS 3.15.4. Notable changes: 1. Move RSA PKCS #1 v1.5, RSA-PSS, and RSA-OAEP code from nss/lib/softoken to nss/lib/freebl. https://bugzilla.mozilla.org/show_bug.cgi?id=836019 2. Use the HTTP GET method for OCSP requests. https://bugzilla.mozilla.org/show_bug.cgi?id=436414 https://bugzilla.mozilla.org/show_bug.cgi?id=928142 3. Improve handling of cached Unknown and Revoked OCSP status. https://bugzilla.mozilla.org/show_bug.cgi?id=933109 4. Don't read from /dev/urandom using fully buffered mode I/O. https://bugzilla.mozilla.org/show_bug.cgi?id=927230 R=agl@chromium.org,rsleevi@chromium.org BUG=331625 TEST=none

Patch Set 1 #

Patch Set 2 : Remove SVN property on new file nss/lib/freebl/rsapkcs.c #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4936 lines, -2216 lines) Patch
M README.chromium View 2 chunks +3 lines, -3 lines 0 comments Download
M nss.gyp View 2 chunks +1 line, -1 line 0 comments Download
M nss/lib/certdb/cert.h View 3 chunks +23 lines, -2 lines 0 comments Download
M nss/lib/certdb/certt.h View 1 chunk +5 lines, -0 lines 0 comments Download
M nss/lib/certdb/polcyxtn.c View 1 chunk +3 lines, -0 lines 0 comments Download
M nss/lib/certhigh/ocsp.h View 1 chunk +9 lines, -0 lines 0 comments Download
M nss/lib/certhigh/ocsp.c View 44 chunks +552 lines, -192 lines 0 comments Download
M nss/lib/certhigh/ocspi.h View 2 chunks +27 lines, -5 lines 0 comments Download
M nss/lib/certhigh/ocspsig.c View 1 chunk +2 lines, -2 lines 0 comments Download
M nss/lib/ckfw/builtins/bfind.c View 1 chunk +4 lines, -3 lines 0 comments Download
M nss/lib/ckfw/builtins/certdata.c View 241 chunks +1119 lines, -741 lines 0 comments Download
M nss/lib/ckfw/builtins/nssckbi.h View 1 chunk +2 lines, -2 lines 0 comments Download
M nss/lib/freebl/blapi.h View 1 chunk +168 lines, -0 lines 0 comments Download
M nss/lib/freebl/dh.c View 3 chunks +22 lines, -1 line 0 comments Download
M nss/lib/freebl/rijndael.c View 3 chunks +25 lines, -2 lines 0 comments Download
A nss/lib/freebl/rsapkcs.c View 1 1 chunk +1382 lines, -0 lines 0 comments Download
M nss/lib/freebl/unix_rand.c View 5 chunks +28 lines, -8 lines 0 comments Download
M nss/lib/libpkix/include/pkix_errorstrings.h View 1 chunk +3 lines, -1 line 0 comments Download
M nss/lib/libpkix/pkix/checker/pkix_ocspchecker.c View 4 chunks +140 lines, -67 lines 0 comments Download
M nss/lib/libpkix/pkix_pl_nss/pki/pkix_pl_ocspcertid.c View 2 chunks +4 lines, -3 lines 0 comments Download
M nss/lib/libpkix/pkix_pl_nss/pki/pkix_pl_ocspresponse.h View 3 chunks +3 lines, -0 lines 0 comments Download
M nss/lib/libpkix/pkix_pl_nss/pki/pkix_pl_ocspresponse.c View 9 chunks +101 lines, -23 lines 0 comments Download
M nss/lib/nss/nss.h View 1 chunk +2 lines, -2 lines 0 comments Download
M nss/lib/pk11wrap/pk11pub.h View 1 chunk +3 lines, -3 lines 0 comments Download
M nss/lib/pk11wrap/secmodi.h View 1 chunk +0 lines, -2 lines 0 comments Download
M nss/lib/smime/smime.h View 1 chunk +2 lines, -2 lines 0 comments Download
M nss/lib/softoken/pkcs11c.c View 21 chunks +411 lines, -82 lines 0 comments Download
M nss/lib/softoken/softkver.h View 1 chunk +2 lines, -2 lines 0 comments Download
M nss/lib/softoken/softoken.h View 1 chunk +14 lines, -112 lines 0 comments Download
M nss/lib/softoken/softoknt.h View 1 chunk +0 lines, -15 lines 0 comments Download
M nss/lib/util/nssutil.h View 1 chunk +2 lines, -2 lines 0 comments Download
M nss/lib/util/secdig.h View 1 chunk +1 line, -1 line 0 comments Download
M nss/lib/util/secdig.c View 1 chunk +2 lines, -1 line 0 comments Download
M patches/nss-chacha20-poly1305.patch View 3 chunks +861 lines, -925 lines 0 comments Download
M patches/nss-urandom-abort.patch View 4 chunks +8 lines, -9 lines 0 comments Download
M scripts/nss-checkout.sh View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
wtc
6 years, 11 months ago (2014-01-07 20:54:43 UTC) #1
agl
Skimming the NSS changes since they have already been reviewed. (By myself in some cases.) ...
6 years, 11 months ago (2014-01-07 21:11:55 UTC) #2
wtc
On 2014/01/07 21:11:55, agl wrote: > > Very excited for Firefox to get OCSP GET ...
6 years, 11 months ago (2014-01-07 22:12:07 UTC) #3
agl
lgtm
6 years, 11 months ago (2014-01-09 18:27:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wtc@chromium.org/105893015/1
6 years, 11 months ago (2014-01-09 18:29:22 UTC) #5
commit-bot: I haz the power
Can't process patch for file nss/lib/freebl/rsapkcs.c. Unsupported svn property format.
6 years, 11 months ago (2014-01-09 18:29:33 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wtc@chromium.org/105893015/200001
6 years, 11 months ago (2014-01-09 18:47:03 UTC) #7
commit-bot: I haz the power
6 years, 11 months ago (2014-01-09 18:48:26 UTC) #8
Message was sent while issue was closed. 
Change committed as 243937

Powered by Google App Engine
This is Rietveld 408576698