Make CreateAndConsumeTexture always associate client_id with a service_id

Make CreateAndConsumeTexture always associate client_id with a service_id

BUG=472465
Committed: https://crrev.com/d8388be01e30b5229893e6dcb8e29748d05649b4
Cr-Commit-Position: refs/heads/master@{#323856}

[bajones, 2015-04-03 17:38:55]

bajones@chromium.org changed reviewers:
+ kbr@chromium.org, piman@chromium.org

[bajones, 2015-04-03 17:38:55]

piman@: I take it this is what you meant by your comments on
https://code.google.com/p/chromium/issues/detail?id=472465#c8 ? Makes sense to
me to have this as a safety mechanism.

[piman, 2015-04-03 18:17:15]

In essence that's what I had in mind, but there's a few things.

Also, could you add a unit test that exercises this case?

https://codereview.chromium.org/1058833004/diff/1/gpu/command_buffer/service/...
File gpu/command_buffer/service/gles2_cmd_decoder.cc (right):

https://codereview.chromium.org/1058833004/diff/1/gpu/command_buffer/service/...
gpu/command_buffer/service/gles2_cmd_decoder.cc:11689: CreateTexture(client_id,
service_id);
I think we also want to do the texture_manager()->SetTarget(texture_ref,
target); (that would be done in BindTexture), to make sure the texture would
have the right target.

Actually, I think we would also want to do the actual glBindTexture to create
the texture on the GL side, but then restore the currently bound texture
(because there shouldn't be the side effect on the context)

It matters in very subtle ways (e.g. if someone tries to bind the texture to a
framebuffer object).

https://codereview.chromium.org/1058833004/diff/1/gpu/command_buffer/service/...
gpu/command_buffer/service/gles2_cmd_decoder.cc:11707:
EnsureTextureForClientId(client_id);
I think it's ok to skip here. We're losing the context anyway (this is what
would happen in the !immediate version).

https://codereview.chromium.org/1058833004/diff/1/gpu/command_buffer/service/...
gpu/command_buffer/service/gles2_cmd_decoder.cc:11711:
EnsureTextureForClientId(client_id);
Here too.

https://codereview.chromium.org/1058833004/diff/1/gpu/command_buffer/service/...
gpu/command_buffer/service/gles2_cmd_decoder.cc:11717:
EnsureTextureForClientId(client_id);
Here too. Because we don't have a valid target, after the suggested change to
EnsureTextureForClientId, we wouldn't be able to SetTarget/glBindTexture anyway.

https://codereview.chromium.org/1058833004/diff/1/gpu/command_buffer/service/...
gpu/command_buffer/service/gles2_cmd_decoder.cc:11723:
EnsureTextureForClientId(client_id);
Here too.

[bajones, 2015-04-03 21:18:03]

Thanks for the feedback! Please take another look.

[piman, 2015-04-03 22:25:04]

Awesome, thanks!
LGTM

[bajones, 2015-04-03 22:25:23]

The CQ bit was checked by bajones@chromium.org

[commit-bot: I haz the power, 2015-04-03 22:26:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1058833004/40001

[commit-bot: I haz the power, 2015-04-04 00:15:54]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-04-04 00:17:31]

Patchset 3 (id:??) landed as
https://crrev.com/d8388be01e30b5229893e6dcb8e29748d05649b4
Cr-Commit-Position: refs/heads/master@{#323856}