Enable both static and dynamically linked libpng

Enable both static and dynamically linked libpng

All platforms except android are configured to use the statically linked copy
of libpng. Android uses the system provided dynamic copy for SkImageDecoder
and the static copy for SkCodec. The exception being android framework builds
that currently use the dynamic copy everywhere.

This CL also enables NEON optimizations for libpng.

Committed: https://skia.googlesource.com/skia/+/b2a6fe7976ae85242f9266be23eab025a7e8e7e7

[djsollen, 2015-04-03 18:39:11]

djsollen@google.com changed reviewers:
+ msarett@google.com, scroggo@google.com

[scroggo, 2015-04-03 18:49:49]

https://codereview.chromium.org/1058823002/diff/10009/gyp/libpng.gyp
File gyp/libpng.gyp (right):

https://codereview.chromium.org/1058823002/diff/10009/gyp/libpng.gyp#newcode81
gyp/libpng.gyp:81: [ 'skia_os != "ios"', {
nit: This is easier to follow if you reverse this:

'skia_os' == 'ios' {
 # ios specific code
}, {
 # other platforms
}

[scroggo, 2015-04-03 18:49:50]

lgtm

[djsollen, 2015-04-03 19:03:20]

https://codereview.chromium.org/1058823002/diff/10009/gyp/libpng.gyp
File gyp/libpng.gyp (right):

https://codereview.chromium.org/1058823002/diff/10009/gyp/libpng.gyp#newcode81
gyp/libpng.gyp:81: [ 'skia_os != "ios"', {
On 2015/04/03 18:49:48, scroggo wrote:
> nit: This is easier to follow if you reverse this:
> 
> 'skia_os' == 'ios' {
>  # ios specific code
> }, {
>  # other platforms
> }

Done.

[djsollen, 2015-04-03 19:03:46]

The CQ bit was checked by djsollen@google.com

[djsollen, 2015-04-03 19:03:46]

The patchset sent to the CQ was uploaded after l-g-t-m from scroggo@google.com
Link to the patchset: https://codereview.chromium.org/1058823002/#ps80001
(title: "rebase")

[commit-bot: I haz the power, 2015-04-03 19:03:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1058823002/80001

[commit-bot: I haz the power, 2015-04-03 19:07:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-03 19:07:56]

Try jobs failed on following builders:
  Build-Win-MSVC-x86-Debug-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86-D...)

[djsollen, 2015-04-03 19:29:27]

The CQ bit was checked by djsollen@google.com

[djsollen, 2015-04-03 19:29:28]

The patchset sent to the CQ was uploaded after l-g-t-m from scroggo@google.com
Link to the patchset: https://codereview.chromium.org/1058823002/#ps100001
(title: "win fix")

[commit-bot: I haz the power, 2015-04-03 19:29:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1058823002/100001

[commit-bot: I haz the power, 2015-04-03 19:35:31]

Committed patchset #7 (id:100001) as
https://skia.googlesource.com/skia/+/b2a6fe7976ae85242f9266be23eab025a7e8e7e7

[msarett, 2015-11-10 20:27:46]

https://codereview.chromium.org/1058823002/diff/1/gyp/libpng.gyp
File gyp/libpng.gyp (right):

https://codereview.chromium.org/1058823002/diff/1/gyp/libpng.gyp#newcode81
gyp/libpng.gyp:81: [ 'skia_os != "ios"', {
Does anybody remember why we don't compile NEON for png on ios?  Is there a bug?

[scroggo, 2015-11-10 21:20:11]

https://codereview.chromium.org/1058823002/diff/1/gyp/libpng.gyp
File gyp/libpng.gyp (right):

https://codereview.chromium.org/1058823002/diff/1/gyp/libpng.gyp#newcode81
gyp/libpng.gyp:81: [ 'skia_os != "ios"', {
On 2015/11/10 20:27:46, msarett wrote:
> Does anybody remember why we don't compile NEON for png on ios?  Is there a
bug?

I do not remember :(

[djsollen, 2015-11-10 21:28:54]

On 2015/11/10 21:20:11, scroggo wrote:
> https://codereview.chromium.org/1058823002/diff/1/gyp/libpng.gyp
> File gyp/libpng.gyp (right):
> 
> https://codereview.chromium.org/1058823002/diff/1/gyp/libpng.gyp#newcode81
> gyp/libpng.gyp:81: [ 'skia_os != "ios"', {
> On 2015/11/10 20:27:46, msarett wrote:
> > Does anybody remember why we don't compile NEON for png on ios?  Is there a
> bug?
> 
> I do not remember :(

Yes, the NEON files failed to compile on iOS and we didn't pursue fixing it at
the time.