Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Issue 1058793004: In "git cl description", skip updating when unchanged (Closed)

Created:
5 years, 8 months ago by wychen
Modified:
5 years, 8 months ago
Reviewers:
Dirk Pranke, nyquist
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org, nyquist
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Project:
tools
Visibility:
Public.

Description

In "git cl description", skip updating when unchanged BUG=473423 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=294671

Patch Set 1 #

Patch Set 2 : reorder #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M git_cl.py View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
wychen
PTAL.
5 years, 8 months ago (2015-04-02 22:42:31 UTC) #2
Dirk Pranke
lgtm. this seems fine, but also seems unnecessary. I'm not sure what the harm is, ...
5 years, 8 months ago (2015-04-02 23:03:06 UTC) #3
wychen
Thanks for the prompt reply. We call "git cl description" in another script, just as ...
5 years, 8 months ago (2015-04-03 00:32:47 UTC) #4
nyquist
dpranke: In https://codereview.chromium.org/1052803002/ I tried just reading the description, and realized that nice little side ...
5 years, 8 months ago (2015-04-03 01:46:25 UTC) #6
Dirk Pranke
ok.
5 years, 8 months ago (2015-04-03 02:01:11 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1058793004/20001
5 years, 8 months ago (2015-04-03 06:48:18 UTC) #9
commit-bot: I haz the power
5 years, 8 months ago (2015-04-03 06:51:47 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=294671

Powered by Google App Engine
This is Rietveld 408576698