Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 1058793002: Support for typed arrays added to Heap::RightTrimFixedArray(). (Closed)

Created:
5 years, 8 months ago by Igor Sheludko
Modified:
5 years, 8 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Support for typed arrays added to Heap::RightTrimFixedArray(). BUG=chromium:472513 LOG=Y Committed: https://crrev.com/ffe886de4816312eece45fd7528d55807d3c51d9 Cr-Commit-Position: refs/heads/master@{#27586}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -6 lines) Patch
M src/heap/heap.cc View 1 2 chunks +21 lines, -4 lines 0 comments Download
M src/objects.h View 2 chunks +3 lines, -0 lines 0 comments Download
M src/objects-inl.h View 3 chunks +12 lines, -2 lines 0 comments Download
M test/cctest/test-heap.cc View 1 chunk +51 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Igor Sheludko
PTAL
5 years, 8 months ago (2015-04-02 10:29:54 UTC) #2
Michael Starzinger
LGTM. https://codereview.chromium.org/1058793002/diff/1/src/heap/heap.cc File src/heap/heap.cc (right): https://codereview.chromium.org/1058793002/diff/1/src/heap/heap.cc#newcode3617 src/heap/heap.cc:3617: Address new_end = object->address() + object->Size() - bytes_to_trim; ...
5 years, 8 months ago (2015-04-02 10:45:27 UTC) #3
Igor Sheludko
https://codereview.chromium.org/1058793002/diff/1/src/heap/heap.cc File src/heap/heap.cc (right): https://codereview.chromium.org/1058793002/diff/1/src/heap/heap.cc#newcode3617 src/heap/heap.cc:3617: Address new_end = object->address() + object->Size() - bytes_to_trim; On ...
5 years, 8 months ago (2015-04-02 11:03:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1058793002/20001
5 years, 8 months ago (2015-04-02 11:03:25 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-02 11:26:16 UTC) #8
commit-bot: I haz the power
5 years, 8 months ago (2015-04-02 11:26:35 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ffe886de4816312eece45fd7528d55807d3c51d9
Cr-Commit-Position: refs/heads/master@{#27586}

Powered by Google App Engine
This is Rietveld 408576698