Remove the allowfullscreen exemption for the video-specific fullscreen API

Remove the allowfullscreen exemption for the video-specific fullscreen API

Intent to Remove:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/3NukIuOaU4c/Boab2WxzhBYJ

Prompted by a question from Ali Alabbas (Microsoft) on blink-dev:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/f-V2GWatXkA/nvdHJ3xihMkJ

TEST=LayoutTests/media/video-controls-fullscreen-iframe.html

This test ensures that the allowfullscreen attribute is still not
required for <video controls>, even though it is for the API call.

BUG=346236
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194106

[philipj_slow, 2015-04-03 09:08:25]

philipj@opera.com changed reviewers:
+ falken@chromium.org

[philipj_slow, 2015-04-03 09:08:25]

PTAL and CQ?

[philipj_slow, 2015-04-03 10:00:43]

Hmm, on second thought I think maybe I should just send an Intent to Deprecate
and Remove the exemption for the Web-exposed video-specific APIs and keep the
counter for the two remaining cases. Use counters 168 and 170 add up to
something like 0.006% and the APIs have been deprecated for a very long time.
Unless you think that's a bad idea, I'll do just that and then adapt this CL.

[falken, 2015-04-03 10:05:41]

On 2015/04/03 10:00:43, philipj_UTC7 wrote:
> Hmm, on second thought I think maybe I should just send an Intent to Deprecate
> and Remove the exemption for the Web-exposed video-specific APIs and keep the
> counter for the two remaining cases. Use counters 168 and 170 add up to
> something like 0.006% and the APIs have been deprecated for a very long time.
> Unless you think that's a bad idea, I'll do just that and then adapt this CL.

Intent to deprecate and remove SGTM

[philipj_slow, 2015-04-17 10:55:48]

Now updated to remove the exemption for the Web-facing API, PTAL.

[falken, 2015-04-20 00:55:59]

This looks good. Do we need to add a test for the <video controls> fullscreen
button exemption, which it looks like full-screen-iframe-legacy.html was meant
to test?

[philipj_slow, 2015-04-20 09:15:23]

On 2015/04/20 00:55:59, falken wrote:
> This looks good. Do we need to add a test for the <video controls> fullscreen
> button exemption, which it looks like full-screen-iframe-legacy.html was meant
> to test?

Good point, there's no test that fails if
MediaControlFullscreenButtonElement::defaultEventHandler uses
Fullscreen::PrefixedRequest instead, so I'll add one.

[philipj_slow, 2015-04-20 12:56:09]

add test for <video controls> case

[philipj_slow, 2015-04-20 12:58:15]

OK, test added, PTAL :)

[falken, 2015-04-21 01:10:09]

lgtm. Thanks for the test!

https://codereview.chromium.org/1058783006/diff/40001/LayoutTests/media/video...
File LayoutTests/media/video-controls-fullscreen-iframe.html (right):

https://codereview.chromium.org/1058783006/diff/40001/LayoutTests/media/video...
LayoutTests/media/video-controls-fullscreen-iframe.html:20: video.src =
findMediaFile("video", "content/test");
nit: single-quotes vs double-quotes for string literals should be consistent
throughout the file

[falken, 2015-04-21 01:10:24]

The CQ bit was checked by falken@chromium.org

[falken, 2015-04-21 01:10:27]

The CQ bit was unchecked by falken@chromium.org

[philipj_slow, 2015-04-21 09:31:59]

https://codereview.chromium.org/1058783006/diff/40001/LayoutTests/media/video...
File LayoutTests/media/video-controls-fullscreen-iframe.html (right):

https://codereview.chromium.org/1058783006/diff/40001/LayoutTests/media/video...
LayoutTests/media/video-controls-fullscreen-iframe.html:20: video.src =
findMediaFile("video", "content/test");
On 2015/04/21 01:10:09, falken wrote:
> nit: single-quotes vs double-quotes for string literals should be consistent
> throughout the file

Yes it should, copy+paste is no excuse! :)

[philipj_slow, 2015-04-21 09:34:21]

consistent quotes

[philipj_slow, 2015-04-21 09:34:39]

The CQ bit was checked by philipj@opera.com

[philipj_slow, 2015-04-21 09:34:40]

The patchset sent to the CQ was uploaded after l-g-t-m from falken@chromium.org
Link to the patchset: https://codereview.chromium.org/1058783006/#ps60001
(title: "consistent quotes")

[commit-bot: I haz the power, 2015-04-21 09:35:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1058783006/60001

[commit-bot: I haz the power, 2015-04-21 11:02:41]

Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194106

[philipj_slow, 2015-06-03 22:51:08]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/1159593006/ by philipj@opera.com.

The reason for reverting is: Feedback from Vimeo on blink-dev asking for more
time:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/3NukIuOaU4c/MPyuWoDa....