Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(672)

Side by Side Diff: Source/core/dom/Node.h

Issue 1058763002: Introduce Node::needsDistributionRecalc and use it in ElementShadow to fix the wrong assertions. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fix Todo in the comment Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | Source/core/dom/Node.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2004-2011, 2014 Apple Inc. All rights reserved. 5 * Copyright (C) 2004-2011, 2014 Apple Inc. All rights reserved.
6 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/) 6 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/)
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Library General Public 9 * modify it under the terms of the GNU Library General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
(...skipping 353 matching lines...) Expand 10 before | Expand all | Expand 10 after
364 bool isLink() const { return getFlag(IsLinkFlag); } 364 bool isLink() const { return getFlag(IsLinkFlag); }
365 bool isEditingText() const { ASSERT(isTextNode()); return getFlag(HasNameOrI sEditingTextFlag); } 365 bool isEditingText() const { ASSERT(isTextNode()); return getFlag(HasNameOrI sEditingTextFlag); }
366 366
367 void setHasName(bool f) { ASSERT(!isTextNode()); setFlag(f, HasNameOrIsEditi ngTextFlag); } 367 void setHasName(bool f) { ASSERT(!isTextNode()); setFlag(f, HasNameOrIsEditi ngTextFlag); }
368 void setChildNeedsStyleRecalc() { setFlag(ChildNeedsStyleRecalcFlag); } 368 void setChildNeedsStyleRecalc() { setFlag(ChildNeedsStyleRecalcFlag); }
369 void clearChildNeedsStyleRecalc() { clearFlag(ChildNeedsStyleRecalcFlag); } 369 void clearChildNeedsStyleRecalc() { clearFlag(ChildNeedsStyleRecalcFlag); }
370 370
371 void setNeedsStyleRecalc(StyleChangeType, const StyleChangeReasonForTracing& ); 371 void setNeedsStyleRecalc(StyleChangeType, const StyleChangeReasonForTracing& );
372 void clearNeedsStyleRecalc(); 372 void clearNeedsStyleRecalc();
373 373
374 #if ENABLE(ASSERT)
375 bool needsDistributionRecalc() const;
376 #endif
377
374 bool childNeedsDistributionRecalc() const { return getFlag(ChildNeedsDistrib utionRecalcFlag); } 378 bool childNeedsDistributionRecalc() const { return getFlag(ChildNeedsDistrib utionRecalcFlag); }
375 void setChildNeedsDistributionRecalc() { setFlag(ChildNeedsDistributionReca lcFlag); } 379 void setChildNeedsDistributionRecalc() { setFlag(ChildNeedsDistributionReca lcFlag); }
376 void clearChildNeedsDistributionRecalc() { clearFlag(ChildNeedsDistribution RecalcFlag); } 380 void clearChildNeedsDistributionRecalc() { clearFlag(ChildNeedsDistribution RecalcFlag); }
377 void markAncestorsWithChildNeedsDistributionRecalc(); 381 void markAncestorsWithChildNeedsDistributionRecalc();
378 382
379 bool childNeedsStyleInvalidation() const { return getFlag(ChildNeedsStyleInv alidationFlag); } 383 bool childNeedsStyleInvalidation() const { return getFlag(ChildNeedsStyleInv alidationFlag); }
380 void setChildNeedsStyleInvalidation() { setFlag(ChildNeedsStyleInvalidation Flag); } 384 void setChildNeedsStyleInvalidation() { setFlag(ChildNeedsStyleInvalidation Flag); }
381 void clearChildNeedsStyleInvalidation() { clearFlag(ChildNeedsStyleInvalida tionFlag); } 385 void clearChildNeedsStyleInvalidation() { clearFlag(ChildNeedsStyleInvalida tionFlag); }
382 void markAncestorsWithChildNeedsStyleInvalidation(); 386 void markAncestorsWithChildNeedsStyleInvalidation();
383 bool needsStyleInvalidation() const { return getFlag(NeedsStyleInvalidationF lag); } 387 bool needsStyleInvalidation() const { return getFlag(NeedsStyleInvalidationF lag); }
(...skipping 522 matching lines...) Expand 10 before | Expand all | Expand 10 after
906 } // namespace blink 910 } // namespace blink
907 911
908 #ifndef NDEBUG 912 #ifndef NDEBUG
909 // Outside the WebCore namespace for ease of invocation from gdb. 913 // Outside the WebCore namespace for ease of invocation from gdb.
910 void showNode(const blink::Node*); 914 void showNode(const blink::Node*);
911 void showTree(const blink::Node*); 915 void showTree(const blink::Node*);
912 void showNodePath(const blink::Node*); 916 void showNodePath(const blink::Node*);
913 #endif 917 #endif
914 918
915 #endif // Node_h 919 #endif // Node_h
OLDNEW
« no previous file with comments | « no previous file | Source/core/dom/Node.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698