Use apple-touch-icons for streamlined hosted apps.

Use apple-touch-icons for streamlined hosted apps.

This patch allows streamlined hosted apps to use the apple touch icons
for generating hosted apps.

To use the icons, it is necessary to size them to
extension_misc::kExtensionIconSizes to make the manifest handler agree
to use the icons.

Added TabHelper::ConstrainBitmapsToSizes which finds the
closest, not-smaller bitmap for each size and downsizes it. At most each
bitmap is used for 1 size in order to prevent generating resized icons
which would be stored on disk.

BUG=318607
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243797

[calamity, 2013-12-31 00:54:19]

Screenshots at crbug.com/318607

[calamity, 2014-01-07 02:41:51]

Moved ConstrainBitmapsToSizes to TabHelper.

[benwells, 2014-01-07 07:03:48]

https://codereview.chromium.org/105873009/diff/280001/chrome/browser/extensio...
File chrome/browser/extensions/tab_helper.cc (right):

https://codereview.chromium.org/105873009/diff/280001/chrome/browser/extensio...
chrome/browser/extensions/tab_helper.cc:374: if (bitmap_it->empty() ||
bitmap_it->width() != bitmap_it->height())
What happens if there are multiple icons available of the same size?

[benwells, 2014-01-08 00:26:07]

lgtm after discussing with chris

[benwells, 2014-01-08 00:26:07]

lgtm after discussing with chris

[calamity, 2014-01-08 23:08:23]

+sky for chrome/common and chrome/renderer OWNERS.

https://codereview.chromium.org/105873009/diff/280001/chrome/browser/extensio...
File chrome/browser/extensions/tab_helper.cc (right):

https://codereview.chromium.org/105873009/diff/280001/chrome/browser/extensio...
chrome/browser/extensions/tab_helper.cc:374: if (bitmap_it->empty() ||
bitmap_it->width() != bitmap_it->height())
On 2014/01/07 07:03:49, benwells wrote:
> What happens if there are multiple icons available of the same size?

They'll end up getting de-duped when being inserted into the map in
ConstrainBitmapsToSizes(), taking the last bitmap in the vector of that size
(which will be the last bitmap in the FaviconMap which is URL keyed).

[sky, 2014-01-09 00:30:35]

LGTM

https://codereview.chromium.org/105873009/diff/280001/chrome/common/web_appli...
File chrome/common/web_application_info.cc (right):

https://codereview.chromium.org/105873009/diff/280001/chrome/common/web_appli...
chrome/common/web_application_info.cc:13:
WebApplicationInfo::WebApplicationInfo() : is_bookmark_app(false),
nit: as you wrapped, wrap whole initializer list to newline.

[commit-bot: I haz the power, 2014-01-09 04:17:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/calamity@chromium.org/105873009/400001

[commit-bot: I haz the power, 2014-01-09 07:33:33]

Change committed as 243797