Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 105873003: Superset of Nacl Keepalive patch & tests - NOT FOR LANDING DIRECTLY. (Closed)

Created:
7 years ago by scheib
Modified:
6 years, 11 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, jam, joi+watch-content_chromium.org, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, native-client-reviews_googlegroups.com
Visibility:
Public.

Description

Superset of Nacl Keepalive patch & tests - NOT FOR LANDING DIRECTLY. https://codereview.chromium.org/61063003/ Implementation. https://codereview.chromium.org/111563006/ Tests. BUG=298339

Patch Set 1 : #

Patch Set 2 : Update after yzshen comments on impl patch 5 #

Patch Set 3 : rebase #

Patch Set 4 : Address test patch 1 comments #

Patch Set 5 : #

Patch Set 6 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+575 lines, -18 lines) Patch
M chrome/browser/extensions/DEPS View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/extensions/app_background_page_apitest.cc View 1 2 3 5 chunks +118 lines, -0 lines 0 comments Download
M chrome/browser/nacl_host/nacl_browser_delegate_impl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/nacl_host/nacl_browser_delegate_impl.cc View 1 2 3 4 5 3 chunks +82 lines, -0 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M components/nacl/browser/nacl_browser_delegate.h View 1 3 chunks +5 lines, -4 lines 0 comments Download
M components/nacl/browser/nacl_process_host.cc View 1 2 3 chunks +8 lines, -1 line 0 comments Download
M components/nacl/browser/test_nacl_browser_delegate.h View 1 chunk +2 lines, -0 lines 0 comments Download
M components/nacl/browser/test_nacl_browser_delegate.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M content/browser/renderer_host/pepper/browser_ppapi_host_impl.h View 1 4 chunks +17 lines, -3 lines 0 comments Download
M content/browser/renderer_host/pepper/browser_ppapi_host_impl.cc View 1 4 chunks +52 lines, -6 lines 0 comments Download
M content/public/browser/browser_ppapi_host.h View 1 2 3 4 2 chunks +15 lines, -0 lines 0 comments Download
M extensions/browser/process_manager.h View 1 2 2 chunks +11 lines, -0 lines 0 comments Download
M extensions/browser/process_manager.cc View 1 2 4 chunks +19 lines, -1 line 0 comments Download
M ppapi/proxy/plugin_globals.h View 1 2 3 chunks +21 lines, -0 lines 0 comments Download
M ppapi/proxy/plugin_globals.cc View 1 2 3 4 5 chunks +45 lines, -2 lines 0 comments Download
M ppapi/proxy/plugin_main_nacl.cc View 1 2 5 chunks +17 lines, -0 lines 0 comments Download
M ppapi/proxy/ppapi_messages.h View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M ppapi/shared_impl/ppapi_globals.h View 1 1 chunk +6 lines, -0 lines 0 comments Download
M ppapi/shared_impl/ppapi_globals.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M ppapi/shared_impl/ppapi_switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M ppapi/shared_impl/ppapi_switches.cc View 1 chunk +3 lines, -0 lines 0 comments Download
A ppapi/tests/extensions/background_keepalive/background.cc View 1 2 3 4 5 1 chunk +63 lines, -0 lines 0 comments Download
A ppapi/tests/extensions/background_keepalive/background.js View 1 chunk +37 lines, -0 lines 0 comments Download
A ppapi/tests/extensions/background_keepalive/manifest.json View 1 chunk +11 lines, -0 lines 0 comments Download
M ppapi/tests/extensions/extensions.gyp View 1 2 3 4 5 1 chunk +19 lines, -0 lines 0 comments Download
M ppapi/thunk/enter.cc View 3 chunks +5 lines, -0 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698