Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Issue 1058723004: Use counter for tabStop. (Closed)

Created:
5 years, 8 months ago by kochi
Modified:
5 years, 8 months ago
Reviewers:
hayato
CC:
blink-reviews, arv+blink, vivekg, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, vivekg_samsung, Inactive, rwlbuis
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

Use counter for tabStop. Adds usecounter for TabStopProperty and TabStopAttribute. These are counted separately. Chromium side change is: https://codereview.chromium.org/1059153002/ BUG=380445 NOTRY=TRUE Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193092

Patch Set 1 #

Patch Set 2 : rebase and renumber #

Patch Set 3 : rebase and renumber again #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M Source/core/dom/Element.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/dom/Element.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/UseCounter.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
kochi
PTAL
5 years, 8 months ago (2015-04-03 04:22:51 UTC) #2
hayato
lgtm
5 years, 8 months ago (2015-04-03 04:45:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1058723004/1
5 years, 8 months ago (2015-04-03 04:47:12 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/50370)
5 years, 8 months ago (2015-04-03 04:51:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1058723004/20001
5 years, 8 months ago (2015-04-03 04:55:18 UTC) #10
commit-bot: I haz the power
Failed to apply patch for Source/core/frame/UseCounter.h: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
5 years, 8 months ago (2015-04-03 06:55:40 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1058723004/40001
5 years, 8 months ago (2015-04-03 07:01:10 UTC) #16
commit-bot: I haz the power
5 years, 8 months ago (2015-04-03 07:01:47 UTC) #17
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=193092

Powered by Google App Engine
This is Rietveld 408576698