Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 1058693003: Revert of C++ readability review (Closed)

Created:
5 years, 8 months ago by falken
Modified:
5 years, 8 months ago
CC:
chromium-reviews, Sameer Nanda, Lei Zhang, blundell
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of C++ readability review (patchset #10 id:180001 of https://codereview.chromium.org/706993003/) Reason for revert: It looks like this broke tests the following tests on Linux Chromium OS: AlarmTimerTest.OneShotTimerConcurrentResetAndTimerFired AlarmTimerTest.RepeatingTimerConcurrentResetAndTimerFired Example output: AlarmTimerTest.OneShotTimerConcurrentResetAndTimerFired (run #1): [ RUN ] AlarmTimerTest.OneShotTimerConcurrentResetAndTimerFired [11334:11334:0406/201742:404219967:INFO:alarm_timer_chromeos.cc(166)] CLOCK_REALTIME_ALARM not supported on this system: Invalid argument [11334:11334:0406/201742:404230154:FATAL:timer.cc(116)] Check failed: !user_task_.is_null(). AlarmTimerTest.RepeatingTimerConcurrentResetAndTimerFired (run #1): [ RUN ] AlarmTimerTest.RepeatingTimerConcurrentResetAndTimerFired [11382:11382:0406/201748:411022458:INFO:alarm_timer_chromeos.cc(166)] CLOCK_REALTIME_ALARM not supported on this system: Invalid argument ../../components/timers/alarm_timer_unittest.cc:469: Failure Value of: did_run Actual: true Expected: false Example build: http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/996 Original issue's description: > C++ readability review > > BUG=b/18275087 > > Committed: https://crrev.com/05e4d854dca737cfb43cd967cd72d024f6b1625b > Cr-Commit-Position: refs/heads/master@{#324004} TBR=derat@chromium.org,gromer@google.com,zea@chromium.org,chirantan@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=b/18275087 Committed: https://crrev.com/0531a97fe4309636fc34af148f21960d3c1614f4 Cr-Commit-Position: refs/heads/master@{#324009}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+717 lines, -798 lines) Patch
M components/gcm_driver/gcm_driver_desktop.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/timers.gypi View 1 chunk +5 lines, -3 lines 0 comments Download
M components/timers/BUILD.gn View 1 chunk +4 lines, -2 lines 0 comments Download
A components/timers/alarm_timer.h View 1 chunk +105 lines, -0 lines 0 comments Download
A components/timers/alarm_timer.cc View 1 chunk +127 lines, -0 lines 0 comments Download
D components/timers/alarm_timer_chromeos.h View 1 chunk +0 lines, -146 lines 0 comments Download
D components/timers/alarm_timer_chromeos.cc View 1 chunk +0 lines, -466 lines 0 comments Download
M components/timers/alarm_timer_unittest.cc View 20 chunks +193 lines, -179 lines 0 comments Download
A components/timers/rtc_alarm.h View 1 chunk +95 lines, -0 lines 0 comments Download
A components/timers/rtc_alarm.cc View 1 chunk +186 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
falken
Created Revert of C++ readability review
5 years, 8 months ago (2015-04-07 03:29:19 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1058693003/1
5 years, 8 months ago (2015-04-07 03:29:38 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-07 03:30:22 UTC) #3
commit-bot: I haz the power
5 years, 8 months ago (2015-04-07 03:31:13 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0531a97fe4309636fc34af148f21960d3c1614f4
Cr-Commit-Position: refs/heads/master@{#324009}

Powered by Google App Engine
This is Rietveld 408576698