scripts/slave/recipes/gpu/build_and_upload.expected/analyze_builds_nothing.json - Issue 1058633004: Added GYP defines to dump linux symbols for gpu perf bots and trybots.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipes/gpu/build_and_upload.expected/analyze_builds_nothing.json

Issue 1058633004: Added GYP defines to dump linux symbols for gpu perf bots and trybots. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: Configured android testers to target platform "android" Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « scripts/slave/recipes/gpu/build_and_test.expected/linux_release_tryserver.json ('k') | scripts/slave/recipes/gpu/build_and_upload.expected/analyze_builds_only_angle_unittests.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipes/gpu/build_and_upload.expected/analyze_builds_nothing.json

diff --git a/scripts/slave/recipes/gpu/build_and_upload.expected/analyze_builds_nothing.json b/scripts/slave/recipes/gpu/build_and_upload.expected/analyze_builds_nothing.json

index dfc6f5d69328baca8e5722cf216991e1ff9676ef..b2597fbcde2d178f1dc741cd7beb9dd32a828b14 100644

--- a/scripts/slave/recipes/gpu/build_and_upload.expected/analyze_builds_nothing.json

+++ b/scripts/slave/recipes/gpu/build_and_upload.expected/analyze_builds_nothing.json

@@ -83,7 +83,7 @@

"runhooks"

"env": {

- "GYP_DEFINES": "archive_gpu_tests=1 blink_logging_always_on=1 component=static_library dcheck_always_on=1 disable_glibcxx_debug=1 ffmpeg_branding=Chrome gomadir='[BUILD]/goma' internal_gles2_conform_tests=1 proprietary_codecs=1 target_arch=x64 test_isolation_mode=prepare use_goma=1"

+ "GYP_DEFINES": "archive_gpu_tests=1 blink_logging_always_on=1 component=static_library dcheck_always_on=1 disable_glibcxx_debug=1 ffmpeg_branding=Chrome gomadir='[BUILD]/goma' internal_gles2_conform_tests=1 linux_dump_symbols=1 proprietary_codecs=1 target_arch=x64 test_isolation_mode=prepare use_goma=1"

"name": "gclient runhooks"

@@ -148,7 +148,7 @@

"/path/to/tmp/json"

"env": {

"name": "analyze",

"~followup_annotations": [