scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_chromium_practice_rel_ng_analyze.json - Issue 1058633004: Added GYP defines to dump linux symbols for gpu perf bots and trybots.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_chromium_practice_rel_ng_analyze.json

Issue 1058633004: Added GYP defines to dump linux symbols for gpu perf bots and trybots. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: Configured android testers to target platform "android" Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_chromium_practice_rel_ng.json ('k') | scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_chromium_rel_ng.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_chromium_practice_rel_ng_analyze.json

diff --git a/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_chromium_practice_rel_ng_analyze.json b/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_chromium_practice_rel_ng_analyze.json

index 6a9db8aa216ccd5b98546027a9f31470571f0b45..eb03e497ae393dfa5d3d634b3b717373993c7694 100644

--- a/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_chromium_practice_rel_ng_analyze.json

+++ b/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_chromium_practice_rel_ng_analyze.json

@@ -74,7 +74,7 @@

"runhooks"

"env": {

- "GYP_DEFINES": "component=static_library dcheck_always_on=1 fastbuild=1 gomadir='[BUILD]/goma' target_arch=x64 use_goma=1"

+ "GYP_DEFINES": "component=static_library dcheck_always_on=1 fastbuild=1 gomadir='[BUILD]/goma' linux_dump_symbols=1 target_arch=x64 use_goma=1"

"name": "gclient runhooks (with patch)"

@@ -164,7 +164,7 @@

"/path/to/tmp/json"

"env": {

- "GYP_DEFINES": "component=static_library dcheck_always_on=1 fastbuild=1 gomadir='[BUILD]/goma' target_arch=x64 use_goma=1"

+ "GYP_DEFINES": "component=static_library dcheck_always_on=1 fastbuild=1 gomadir='[BUILD]/goma' linux_dump_symbols=1 target_arch=x64 use_goma=1"

"name": "analyze",

"~followup_annotations": [