scripts/slave/recipe_modules/chromium/config.py - Issue 1058633004: Added GYP defines to dump linux symbols for gpu perf bots and trybots.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipe_modules/chromium/config.py

Issue 1058633004: Added GYP defines to dump linux symbols for gpu perf bots and trybots. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: Configured android testers to target platform "android" Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: scripts/slave/recipe_modules/chromium/config.py

diff --git a/scripts/slave/recipe_modules/chromium/config.py b/scripts/slave/recipe_modules/chromium/config.py

index 378841bfba43efb53f55c9d323365be7b391c4cc..9a8e5bfcf14b0bf2430e5d29821c0384bce0bd31 100644

--- a/scripts/slave/recipe_modules/chromium/config.py

+++ b/scripts/slave/recipe_modules/chromium/config.py

@@ -487,6 +487,7 @@ def _memory_tool(c, tool):

def trybot_flavor(c):

fastbuild(c, optional=True)

dcheck(c, optional=True)

+ linux_dump_symbols(c)

@config_ctx()

def gn_component_build(c):

@@ -750,6 +751,11 @@ def chromium_pgo_optimize(c):

c.gyp_env.GYP_DEFINES['chrome_pgo_phase'] = 2

@config_ctx()

+def linux_dump_symbols(c):

+ if c.TARGET_PLATFORM == 'linux':

+ c.gyp_env.GYP_DEFINES['linux_dump_symbols'] = 1

+@config_ctx()

def v8_optimize_medium(c):

c.gyp_env.GYP_DEFINES['v8_optimized_debug'] = 1

c.gyp_env.GYP_DEFINES['v8_enable_slow_dchecks'] = 1

« no previous file with comments | « no previous file | scripts/slave/recipe_modules/gpu/api.py » ('j') | no next file with comments »