scripts/slave/recipes/android/tester.expected/chromium_fyi_Android_Tests__N5_.json - Issue 1058633004: Added GYP defines to dump linux symbols for gpu perf bots and trybots.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipes/android/tester.expected/chromium_fyi_Android_Tests__N5_.json

Issue 1058633004: Added GYP defines to dump linux symbols for gpu perf bots and trybots. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« scripts/slave/recipe_modules/chromium/config.py ('K') | « scripts/slave/recipes/android/tester.expected/android_dbg_tests_recipe__content_browsertests_failure.json ('k') | scripts/slave/recipes/android/tester.expected/no_compile_because_of_analyze.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipes/android/tester.expected/chromium_fyi_Android_Tests__N5_.json

diff --git a/scripts/slave/recipes/android/tester.expected/chromium_fyi_Android_Tests__N5_.json b/scripts/slave/recipes/android/tester.expected/chromium_fyi_Android_Tests__N5_.json

index f104dc88ec155e55b7cf7e0e88814c813c707811..b89c8d7bcaa972639a1f4f56d6f811c3970ff08e 100644

--- a/scripts/slave/recipes/android/tester.expected/chromium_fyi_Android_Tests__N5_.json

+++ b/scripts/slave/recipes/android/tester.expected/chromium_fyi_Android_Tests__N5_.json

@@ -96,7 +96,7 @@

"env": {

"GYP_CROSSCOMPILE": "1",

- "GYP_DEFINES": "OS=android component=static_library dcheck_always_on=1 fastbuild=1 gomadir='[BUILD]/goma' target_arch=arm use_goma=1",

+ "GYP_DEFINES": "OS=android component=static_library dcheck_always_on=1 fastbuild=1 gomadir='[BUILD]/goma' linux_dump_symbols=1 target_arch=arm use_goma=1",

"PATH": "[SLAVE_BUILD]/src/third_party/android_tools/sdk/platform-tools:[SLAVE_BUILD]/src/build/android:%(PATH)s"

"name": "gclient runhooks"

@@ -152,7 +152,7 @@

"env": {

"GYP_CROSSCOMPILE": "1",

- "GYP_DEFINES": "OS=android component=static_library dcheck_always_on=1 fastbuild=1 gomadir='[BUILD]/goma' target_arch=arm use_goma=1"

+ "GYP_DEFINES": "OS=android component=static_library dcheck_always_on=1 fastbuild=1 gomadir='[BUILD]/goma' linux_dump_symbols=1 target_arch=arm use_goma=1"

"name": "analyze",

"~followup_annotations": [